Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HostWriter fails to copy version resource on non-Windows platforms #486

Closed
szilvaa opened this issue Dec 3, 2019 · 4 comments
Closed

HostWriter fails to copy version resource on non-Windows platforms #486

szilvaa opened this issue Dec 3, 2019 · 4 comments
Assignees
Labels
area-HostModel Microsoft.NET.HostModel issues
Milestone

Comments

@szilvaa
Copy link

szilvaa commented Dec 3, 2019

I'm building a Win64 executable on Linux. It works very well except that the resulting executable has no version info. It tracked this down to HostWriter class in this repo. In particular this line. The code only copies resource on Windows.
Steps to repro:

  1. Create .net core console app targeting Win64.
  2. Make sure that your project file has <Version> attribute.
  3. Build the app on Linux.
    Expected result: the resulting exe has version resource. (In fact it does have this when you build on Windows)
    Actual result: no version resource in the resulting exe.
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Dec 3, 2019
@maryamariyan maryamariyan added the area-HostModel Microsoft.NET.HostModel issues label Dec 3, 2019
@vitek-karas
Copy link
Member

This currently a known limitation.
@sbomer - do we have a master issue tracking this? (or should we use this one).

@sbomer
Copy link
Member

sbomer commented Dec 31, 2019

@vitek-karas Let's use this to track it.

With the current resource updater, I think we should at least be outputting a warning in this case. It looks like https://github.com/dotnet/sdk/pull/3447/files#diff-0a0bced361e8a4b1eeaaa2c34a320a68R47 restricted the apphost customization warning to GUI apps. @wli3 was there a particular reason for this, and do you think it's worth logging a warning for console apps too?

@jeffschwMSFT jeffschwMSFT removed the untriaged New issue has not been triaged by the area owner label Jan 8, 2020
@jeffschwMSFT jeffschwMSFT added this to the 5.0 milestone Jan 8, 2020
@swaroop-sridhar
Copy link
Contributor

This problem will be fixed once #3828 is completed.

@swaroop-sridhar swaroop-sridhar self-assigned this Jun 17, 2020
@swaroop-sridhar
Copy link
Contributor

Dup of #3828

@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-HostModel Microsoft.NET.HostModel issues
Projects
None yet
Development

No branches or pull requests

7 participants