Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build size regressions #49081

Closed
pr-benchmarks bot opened this issue Mar 3, 2021 · 9 comments
Closed

Build size regressions #49081

pr-benchmarks bot opened this issue Mar 3, 2021 · 9 comments
Labels
area-VM-coreclr untriaged New issue has not been triaged by the area owner

Comments

@pr-benchmarks
Copy link

pr-benchmarks bot commented Mar 3, 2021 •
edited by sebastienros
Loading

A publish size regression has been detected for the following scenarios:

Scenario Environment Date Old Build (KB) New Build (KB) Change Deviation StDev
json Json CG2 composite aspnet-citrine-amd 02/19/2021 08:34:23 151,273 328,772 117 % (177,499) 👎 12,083.99 σ 15
json Json CG2 non-composite aspnet-citrine-amd 02/19/2021 08:35:31 123,245 300,724 144 % (177,479) 👎 15,876.74 σ 11
json Json CG2 composite avx2 aspnet-citrine-amd 02/19/2021 08:36:59 151,786 329,285 116 % (177,499) 👎 11,823.81 σ 15

Changes:

Runtime Previous Version Current Version Diff
ASP.NET n/a n/a n/a
CLR n/a n/a n/a
SDK 6.0.100-preview.2.21120.3 6.0.100-preview.3.21123.18 n/a

@sebastienros
@mangod9
@sebastienros
Copy link
Member

sebastienros commented Mar 3, 2021 •
edited
Loading

Regression in build size impact all self-contained apps, isolated with

3e85099...1db079d

| .NET Runtime Version  | 6.0.0-preview.2.21118.6+3e85099234a06ff36915b0c11289bcfe6787fc66 |
| .NET Runtime Version  | 6.0.0-preview.2.21118.10+1db079d19538a7520ec6c74f0566b4b78c7e935d |

@sebastienros
Copy link
Member

Before

image

After

image

@sebastienros
Copy link
Member

Commands to repro:

crank --config https://raw.githubusercontent.com/aspnet/Benchmarks/master/scenarios/platform.benchmarks.yml --scenario json --profile aspnet-perf-lin --variable warmup=0 --variable duration=1 --application.framework net6.0 --application.runtimeversion 6.0.0-preview.2.21118.6

crank --config https://raw.githubusercontent.com/aspnet/Benchmarks/master/scenarios/platform.benchmarks.yml --scenario json --profile aspnet-perf-lin --variable warmup=0 --variable duration=1 --application.framework net6.0 --application.runtimeversion 6.0.0-preview.2.21118.10

Add --application.options.fetch true to download the published apps

@sebastienros sebastienros transferred this issue from dotnet/aspnetcore Mar 3, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI untriaged New issue has not been triaged by the area owner labels Mar 3, 2021
@sebastienros sebastienros changed the title Performance difference: json, json, json, json, json ... Build size regressions Mar 3, 2021
@mangod9 mangod9 added area-VM-coreclr and removed area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Mar 3, 2021
@mangod9
Copy link
Member

mangod9 commented Mar 3, 2021

moving to VM for now, looks like all native binaries increased in size.

@mangod9
Copy link
Member

mangod9 commented Mar 3, 2021

FYI @jkoritzinsky @trylek @jkotas if they are aware of any build changes around symbols not getting stripped or something similar?

@EgorBo
Copy link
Member

EgorBo commented Mar 3, 2021

Can it be #48444 from that list of commits?
cc @am11

@jkotas
Copy link
Member

jkotas commented Mar 3, 2021

Can it be #48444 from that list of commits?

I agree that this is the problematic change. cc @janvorli

I think we should revert it. Thoughts? Also, we may want to push the revert into preview2 since the bug is there as well.

@jkotas
Copy link
Member

jkotas commented Mar 3, 2021

#49092

@jkotas
Copy link
Member

jkotas commented Mar 4, 2021

Fixed by #49092

@jkotas jkotas closed this as completed Mar 4, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Apr 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-VM-coreclr untriaged New issue has not been triaged by the area owner
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@EgorBo @sebastienros @jkotas @mangod9