Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.Drawing.Common targeting Unix framework is too broad #49479

Closed
marek-safar opened this issue Mar 11, 2021 · 2 comments
Closed

System.Drawing.Common targeting Unix framework is too broad #49479

marek-safar opened this issue Mar 11, 2021 · 2 comments

Comments

@marek-safar
Copy link
Contributor

<TargetFrameworks>$(NetCoreAppCurrent)-windows;$(NetCoreAppCurrent)-Unix;$(NetCoreAppCurrent);netcoreapp3.0-windows;netcoreapp3.0-Unix;netcoreapp3.0</TargetFrameworks>
targets Unix TFM but in reality, the assembly is supported only on few Unix platforms.

The target needs to be updated to exclude all Unix-like platforms where the assembly is not supported or even better would be to retarget it for Linux and macOS only where it's only supported.

@dotnet-issue-labeler dotnet-issue-labeler bot added area-System.Drawing untriaged New issue has not been triaged by the area owner labels Mar 11, 2021
@ghost
Copy link

ghost commented Mar 11, 2021

Tagging subscribers to this area: @safern, @tarekgh
See info in area-owners.md if you want to be subscribed.

Issue Details

<TargetFrameworks>$(NetCoreAppCurrent)-windows;$(NetCoreAppCurrent)-Unix;$(NetCoreAppCurrent);netcoreapp3.0-windows;netcoreapp3.0-Unix;netcoreapp3.0</TargetFrameworks>
targets Unix TFM but in reality, the assembly is supported only on few Unix platforms.

The target needs to be updated to exclude all Unix-like platforms where the assembly is not supported or even better would be to retarget it for Linux and macOS only where it's only supported.

Author: marek-safar
Assignees: -
Labels:

area-System.Drawing, untriaged

Milestone: -

@safern
Copy link
Member

safern commented Jul 22, 2021

Given that we annotated this assembly as SupportedOSPlatform("Windows") and that we are no longer supporting System.Drawing.Common on non-windows. I will close this issue as it is no longer applicable and once main becomes .NET 7, I will nuke the Unix implementation.

@safern safern closed this as completed Jul 22, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants