Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create checked/release SuperPMI asm diffs AzDO pipeline #49949

Closed
Tracked by #64832
BruceForstall opened this issue Mar 21, 2021 · 2 comments
Closed
Tracked by #64832

Create checked/release SuperPMI asm diffs AzDO pipeline #49949

BruceForstall opened this issue Mar 21, 2021 · 2 comments
Assignees
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone

Comments

@BruceForstall
Copy link
Member

BruceForstall commented Mar 21, 2021

We need a test to ensure there are no differences in codegen between DEBUG and non-DEBUG compilers (e.g., Checked and Release), since we do most of our testing on Checked, and debugging Release is difficult and tedious, at best. One way to do this is run SuperPMI asm diffs between a Checked and Release build of the JIT.

I propose adding an AzDO pipeline to do this.

Notes:

  • Of course, it should be all platform.
  • We only need Checked and Release JIT builds, no builds of the full runtime or tests. The "jitrollingbuild" pipeline already builds just the Checked JITs. We should copy/leverage its logic to build both Checked and Release JITs.
  • The Helix machines need to run, basically:
    • python superpmi.py -base_jit_path <Release JIT> -diff_jit_path <Checked JIT>
  • If the Helix machines can't access Azure Storage to automatically download the MCH files, we can download the files on the build machine, and add them to the test payload (i.e., copy them from the build machine to the Helix machine.)
    • in this case, just pass -mch_files ... to point at the MCH files
  • the job should fail if there are any DEBUG/non-DEBUG asm diffs
  • trigger the job on JIT PRs, or, if that is deemed too expensive, run it weekly (and ensure the results are reviewed).
  • The logic will be very similar to the superpmi-replay pipeline created with Spmi replay pipeline #56871.

@kunalspathak @AndyAyersMS @dotnet/jit-contrib

@BruceForstall BruceForstall added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 21, 2021
@BruceForstall BruceForstall added this to the Future milestone Mar 21, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Mar 21, 2021
@BruceForstall BruceForstall removed the untriaged New issue has not been triaged by the area owner label Mar 21, 2021
@jkoritzinsky
Copy link
Member

Related: #5884

@JulieLeeMSFT
Copy link
Member

Closed by #61335.

@ghost ghost locked as resolved and limited conversation to collaborators Apr 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

No branches or pull requests

3 participants