-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider adding the build of NCL stress and enterprise tests to the mandatory legs of the CI #51120
Comments
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer Issue DetailsCurrently there is no CI guarantee to make sure these projects are not broken. PR #49706 fixed such a regression, but in a few weeks the build got broken again (#51117) with a reason that is far from being obvious. We should consider running build-only variants of The lack of such an automation makes it really hard to keep these projects functional while the underlying infrastructure is being refactored. cc @ViktorHofer
|
Some thoughts we just had during triaging:
Feel free to submit a PR to add the leg to build as part of CI. Will move this to future meanwhile. |
Currently there is no CI guarantee to make sure these projects are not broken. PR #49706 fixed such a regression, but in a few weeks the build got broken again (#51117) with a reason that is far from being obvious.
We should consider running build-only variants of
stress/http.yml
,stress/ssl.yml
andenterprise/linux.yml
as a mandatory PR checks.The lack of such an automation makes it really hard to keep these projects functional while the underlying infrastructure is being refactored.
cc @ViktorHofer
Edit 1: An alternative could be an agreement to run those pipelines on infrastructure changes.
Edit 2: The root cause of #51117 was a library bug (#51141) breaking the SDK, meaning that guarding the infra changes only might be insufficient, but this looks like an exceptional case.
The text was updated successfully, but these errors were encountered: