Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm][tests] Tracking issue for errors with EnableAggressiveTrimming, for building AOT tests #51249

Open
radical opened this issue Apr 14, 2021 · 2 comments
Labels
arch-wasm WebAssembly architecture area-Build-mono tracking This issue is tracking the completion of other related issues. trimming-for-aot `EnableAggressiveTrimming=true` used for running tests with AOT
Milestone

Comments

@radical
Copy link
Member

radical commented Apr 14, 2021

To enable running tests with AOT, we need to use $(EnableAggressiveTrimming)==true, to reduce the AOT build time. Enabling this introduces some build issues, or test failures though.

To reproduce locally:

  1. $ /dotnet.sh build /p:Configuration=Release /p:TargetOS=Browser /p:TargetArchitecture=wasm /t:Test /path/to/project/file /p:EnableAggressiveTrimming=true
  2. If you are not able to reproduce it with the above, then try building with /p:BuildAOTTestsOnHelix=true to the above command line
  3. If you still cannot reproduce, then ask on the discord channel, as it might be a helix issue

tips:

  • make sure to assign the issue to yourself, if you are working on it
  • You can add /p:DebuggerSupport=true to get line numbers
@radical radical added arch-wasm WebAssembly architecture area-Build-mono trimming-for-aot `EnableAggressiveTrimming=true` used for running tests with AOT labels Apr 14, 2021
@ghost
Copy link

ghost commented Apr 14, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

To enable running tests with AOT, we need to use $(EnableAggressiveTrimming)==true, to reduce the AOT build time. Enabling this introduces some build issues, or test failures though.

To reproduce locally:

  1. use the branch from the second PR
  2. $ /dotnet.sh build /p:Configuration=Release /p:TargetOS=Browser /p:TargetArchitecture=wasm /t:Test /path/to/project/file /p:EnableAggressiveTrimming=true
  3. If you are not able to reproduce it with the above, then try building with /p:BuildAOTTestsOnHelix=true to the above command line
  4. If you still cannot reproduce, then ask on the discord channel, as it might be a helix issue

tips:

  • make sure to assign the issue to yourself, if you are working on it
  • You can add /p:DebuggerSupport=true to get line numbers
Author: radical
Assignees: -
Labels:

arch-wasm, area-Build-mono, trimming-for-aot

Milestone: -

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Apr 14, 2021
@radical
Copy link
Member Author

radical commented Apr 14, 2021

@lewing lewing removed the untriaged New issue has not been triaged by the area owner label Jun 17, 2021
@lewing lewing added this to the 6.0.0 milestone Jun 17, 2021
@marek-safar marek-safar added the tracking This issue is tracking the completion of other related issues. label Jul 2, 2021
@lewing lewing modified the milestones: 6.0.0, Future Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-wasm WebAssembly architecture area-Build-mono tracking This issue is tracking the completion of other related issues. trimming-for-aot `EnableAggressiveTrimming=true` used for running tests with AOT
Projects
None yet
Development

No branches or pull requests

3 participants