Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test System.ComponentModel.Tests.ReflectionCachesUpdateHandlerTests.ReflectionCachesUpdateHandler_CachesCleared is failing on mono OSX x64 #51588

Closed
jeffhandley opened this issue Apr 20, 2021 · 4 comments · Fixed by #51621
Closed

Test System.ComponentModel.Tests.ReflectionCachesUpdateHandlerTests.ReflectionCachesUpdateHandler_CachesCleared is failing on mono OSX x64 #51588

jeffhandley opened this issue Apr 20, 2021 · 4 comments · Fixed by #51621
Assignees
@stephentoub
Labels
area-System.ComponentModel blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' bug

Comments

@jeffhandley
Copy link
Member

jeffhandley commented Apr 20, 2021 •
edited by runfoapp bot
Loading

System.ComponentModel.Tests.ReflectionCachesUpdateHandlerTests.ReflectionCachesUpdateHandler_CachesCleared

This test was added in #51466 and it is failing on mono OSX x64.

Console Log Summary

  Discovering: System.ComponentModel.TypeConverter.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.ComponentModel.TypeConverter.Tests (found 1371 of 1372 test cases)
  Starting:    System.ComponentModel.TypeConverter.Tests (parallel test collections = on, max threads = 12)
    System.ComponentModel.Tests.ReflectionCachesUpdateHandlerTests.ReflectionCachesUpdateHandler_CachesCleared [FAIL]
      System.InvalidOperationException : Collection was modified; enumeration operation may not execute.
      Stack Trace:
        /_/src/libraries/System.Private.CoreLib/src/System/Collections/Hashtable.cs(1471,0): at System.Collections.Hashtable.HashtableEnumerator.MoveNext()
        /_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/ReflectTypeDescriptionProvider.cs(843,0): at System.ComponentModel.ReflectTypeDescriptionProvider.GetPopulatedTypes(Module module)
        /_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs(2352,0): at System.ComponentModel.TypeDescriptor.Refresh(Module module)
        /_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs(2392,0): at System.ComponentModel.TypeDescriptor.Refresh(Assembly assembly)
        /_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/ReflectionCachesUpdateHandler.cs(34,0): at System.ComponentModel.ReflectionCachesUpdateHandler.BeforeUpdate(Type[] types)
        /_/src/mono/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.cs(378,0): at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
  Finished:    System.ComponentModel.TypeConverter.Tests
=== TEST EXECUTION SUMMARY ===
   System.ComponentModel.TypeConverter.Tests  Total: 7747, Errors: 0, Failed: 1, Skipped: 0, Time: 1.659s

Configurations

  • net6.0-OSX-Debug-x64-Mono_release-OSX.1015.Amd64.Open

Builds

Build Pull Request
1098117 #51575
1098170 #51550

/cc @stephentoub

Runfo Tracking Issue: Test reflectioncachesupdatehandlertests.reflectioncachesupdatehandler_cachescleared failed

Build Definition Kind Run Name
1099152 runtime PR 51589 net6.0-OSX-Debug-x64-CoreCLR_release-OSX.1015.Amd64.Open
1099152 runtime PR 51589 net6.0-OSX-Debug-x64-Mono_release-OSX.1014.Amd64.Open
1099089 runtime PR 48226 net6.0-OSX-Debug-x64-Mono_release-OSX.1015.Amd64.Open
1099089 runtime PR 48226 net6.0-Linux-Debug-x64-Mono_release-Ubuntu.1604.Amd64.Open
1099030 runtime PR 51604 net6.0-Linux-Debug-arm64-Mono_release-(Ubuntu.1804.ArmArch.Open)Ubuntu.1804.ArmArch.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-16.04-helix-arm64v8-20210106155927-56c6673
1098811 runtime PR 51530 net6.0-Linux-Debug-x64-Mono_release-Ubuntu.1804.Amd64.Open
1098811 runtime PR 51530 net6.0-OSX-Debug-x64-Mono_release-OSX.1014.Amd64.Open
1098690 runtime PR 51505 net6.0-Linux-Release-arm64-CoreCLR_checked-(Alpine.312.Arm64.Open)Ubuntu.1804.ArmArch.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:alpine-3.12-helix-arm64v8-20200602002604-25f8a3e
1098170 runtime PR 51550 net6.0-OSX-Debug-x64-Mono_release-OSX.1014.Amd64.Open
1098117 runtime PR 51575 net6.0-OSX-Debug-x64-Mono_release-OSX.1015.Amd64.Open
1098089 runtime PR 51528 net6.0-OSX-Debug-x64-CoreCLR_checked-OSX.1013.Amd64.Open
1098051 runtime Rolling net6.0-Linux-Release-x64-Mono_release-Debian.9.Amd64.Open

Build Result Summary

Day Hit Count Week Hit Count Month Hit Count
9 9 9
@jeffhandley jeffhandley added test-bug Problem in test source code (most likely) blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' labels Apr 20, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added area-System.ComponentModel untriaged New issue has not been triaged by the area owner labels Apr 20, 2021
@ghost
Copy link

ghost commented Apr 20, 2021

Tagging subscribers to this area: @safern
See info in area-owners.md if you want to be subscribed.

Issue Details

System.ComponentModel.Tests.ReflectionCachesUpdateHandlerTests.ReflectionCachesUpdateHandler_CachesCleared

This test was added in #51466 and it is failing on mono OSX x64.

Console Log Summary

  Discovering: System.ComponentModel.TypeConverter.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.ComponentModel.TypeConverter.Tests (found 1371 of 1372 test cases)
  Starting:    System.ComponentModel.TypeConverter.Tests (parallel test collections = on, max threads = 12)
    System.ComponentModel.Tests.ReflectionCachesUpdateHandlerTests.ReflectionCachesUpdateHandler_CachesCleared [FAIL]
      System.InvalidOperationException : Collection was modified; enumeration operation may not execute.
      Stack Trace:
        /_/src/libraries/System.Private.CoreLib/src/System/Collections/Hashtable.cs(1471,0): at System.Collections.Hashtable.HashtableEnumerator.MoveNext()
        /_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/ReflectTypeDescriptionProvider.cs(843,0): at System.ComponentModel.ReflectTypeDescriptionProvider.GetPopulatedTypes(Module module)
        /_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs(2352,0): at System.ComponentModel.TypeDescriptor.Refresh(Module module)
        /_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs(2392,0): at System.ComponentModel.TypeDescriptor.Refresh(Assembly assembly)
        /_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/ReflectionCachesUpdateHandler.cs(34,0): at System.ComponentModel.ReflectionCachesUpdateHandler.BeforeUpdate(Type[] types)
        /_/src/mono/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.cs(378,0): at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
  Finished:    System.ComponentModel.TypeConverter.Tests
=== TEST EXECUTION SUMMARY ===
   System.ComponentModel.TypeConverter.Tests  Total: 7747, Errors: 0, Failed: 1, Skipped: 0, Time: 1.659s

Configurations

  • Libraries Test Run release mono OSX x64 Debug

Builds

Build Pull Request
1098117 #51575
1098170 #51550

/cc @stephentoub

Author: jeffhandley
Assignees: -
Labels:

area-System.ComponentModel, blocking-clean-ci, test bug, untriaged
Milestone: -

@jeffhandley
Copy link
Member Author

https://runfo.azurewebsites.net/search/tests/?q=definition%3Aruntime+name%3A%22system.componentmodel.tests.reflectioncachesupdatehandlertests.reflectioncachesupdatehandler_cachescleared%22

@runfoapp runfoapp bot mentioned this issue Apr 20, 2021
Closed
This was referenced Apr 20, 2021
Merged
Merged
@stephentoub stephentoub mentioned this issue Apr 21, 2021
Closed
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Apr 21, 2021
@radical radical mentioned this issue Apr 21, 2021
Merged
@VincentBu
Copy link
Contributor

Failed again in runtime 20210420.45

Failed test:

net6.0-Linux-Release-x64-Mono_release-Debian.9.Amd64.Open
 -System.ComponentModel.Tests.ReflectionCachesUpdateHandlerTests.ReflectionCachesUpdateHandler_CachesCleared

Error message:

System.InvalidOperationException : Collection was modified; enumeration operation may not execute.


Stack trace
   at System.Collections.Hashtable.HashtableEnumerator.MoveNext() in /_/src/libraries/System.Private.CoreLib/src/System/Collections/Hashtable.cs:line 1471
   at System.ComponentModel.ReflectTypeDescriptionProvider.GetPopulatedTypes(Module module) in /_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/ReflectTypeDescriptionProvider.cs:line 843
   at System.ComponentModel.TypeDescriptor.Refresh(Module module) in /_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs:line 2352
   at System.ComponentModel.TypeDescriptor.Refresh(Assembly assembly) in /_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs:line 2392
   at System.ComponentModel.ReflectionCachesUpdateHandler.BeforeUpdate(Type[] types) in /_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/ReflectionCachesUpdateHandler.cs:line 34
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture) in /_/src/mono/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.cs:line 378

@GrabYourPitchforks GrabYourPitchforks mentioned this issue Apr 21, 2021
Merged
@radical radical mentioned this issue Apr 21, 2021
Merged
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Apr 21, 2021
@stephentoub stephentoub mentioned this issue Apr 21, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Apr 21, 2021
@stephentoub stephentoub self-assigned this Apr 21, 2021
@stephentoub stephentoub added bug and removed test-bug Problem in test source code (most likely) untriaged New issue has not been triaged by the area owner labels Apr 21, 2021
@stephentoub
Copy link
Member

#51618 is the root cause. #51621 has a fix.

@lewing lewing mentioned this issue Apr 21, 2021
Merged
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Apr 21, 2021
@ghost ghost locked as resolved and limited conversation to collaborators May 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@stephentoub stephentoub

Labels
area-System.ComponentModel blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' bug
Projects
None yet
Milestone
No milestone
3 participants
@jeffhandley @stephentoub @VincentBu