Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm][eat] Trimming error in System.ComponentModel.Tests - Type name strings used for dynamically accessing a type should be assembly qualified #51646

Closed
radical opened this issue Apr 21, 2021 · 2 comments
Labels
arch-wasm WebAssembly architecture area-System.ComponentModel trimming-for-aot `EnableAggressiveTrimming=true` used for running tests with AOT untriaged New issue has not been triaged by the area owner

Comments

@radical
Copy link
Member

radical commented Apr 21, 2021

  • Make sure to change the trimmer descriptor filename in src/libraries/System.ComponentModel.TypeConverter/tests/System.ComponentModel.TypeConverter.Tests.csproj:
-    <TrimmerRootDescriptor Include="$(MSBuildThisFileDirectory)ILLink.Descriptor.xml" />
+    <TrimmerRootDescriptor Include="$(MSBuildThisFileDirectory)ILLink.Descriptors.xml" />
  • Build with /p:EnableAggressiveTrimming=true

  • Build

  System.ComponentModel.TypeConverter.Tests -> /Users/radical/dev/r3/artifacts/bin/System.ComponentModel.TypeConverter.Tests/net6.0-Release/browser-wasm/System.ComponentModel.TypeConverter.Tests.dll
/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/AttributeProviderAttributeTests.cs(23,82): error IL2105: System.ComponentModel.Tests.AttributeProviderAttributeTests.<>c.<Ctor_NullPropertyName_ThrowsArgumentNullException>b__1_0(): Type 'typeN
ame' was not found in the caller assembly nor in the base library. Type name strings used for dynamically accessing a type should be assembly qualified. [/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/System.ComponentModel.TypeConverter.Tes
ts.csproj]
/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/ProvidePropertyAttributeTests.cs(16707566): error IL2105: System.ComponentModel.ProvidePropertyAttributeTests.<Equals_TestData>d__3.MoveNext(): Type 'receiverTypeName' was not found in the call
er assembly nor in the base library. Type name strings used for dynamically accessing a type should be assembly qualified. [/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/System.ComponentModel.TypeConverter.Tests.csproj]
/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/ProvidePropertyAttributeTests.cs(16707566): error IL2105: System.ComponentModel.ProvidePropertyAttributeTests.<Equals_TestData>d__3.MoveNext(): Type 'receiverTypeName' was not found in the call
er assembly nor in the base library. Type name strings used for dynamically accessing a type should be assembly qualified. [/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/System.ComponentModel.TypeConverter.Tests.csproj]
/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/ProvidePropertyAttributeTests.cs(16707566): error IL2105: System.ComponentModel.ProvidePropertyAttributeTests.<Equals_TestData>d__3.MoveNext(): Type 'receiverTypeName' was not found in the call
er assembly nor in the base library. Type name strings used for dynamically accessing a type should be assembly qualified. [/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/System.ComponentModel.TypeConverter.Tests.csproj]
/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/ProvidePropertyAttributeTests.cs(16707566): error IL2105: System.ComponentModel.ProvidePropertyAttributeTests.<Equals_TestData>d__3.MoveNext(): Type 'receiverTypeName' was not found in the call
er assembly nor in the base library. Type name strings used for dynamically accessing a type should be assembly qualified. [/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/System.ComponentModel.TypeConverter.Tests.csproj]
/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/ProvidePropertyAttributeTests.cs(16707566): error IL2105: System.ComponentModel.ProvidePropertyAttributeTests.<Equals_TestData>d__3.MoveNext(): Type 'receivertypename' was not found in the call
er assembly nor in the base library. Type name strings used for dynamically accessing a type should be assembly qualified. [/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/System.ComponentModel.TypeConverter.Tests.csproj]
/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/ProvidePropertyAttributeTests.cs(16707566): error IL2105: System.ComponentModel.ProvidePropertyAttributeTests.<Equals_TestData>d__3.MoveNext(): Type 'receiverTypeName' was not found in the caller assembly nor in the base library. Type name strings used for dynamically accessing a type should be assembly qualified. [/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/System.ComponentModel.TypeConverter.Tests.csproj]
/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/InstallerTypeAttributeTests.cs(16707566): error IL2105: System.ComponentModel.Tests.InstallerTypeAttributeTests.<Equals_TestData>d__5.MoveNext(): Type 'typename' was not found in the caller assembly nor in the base library. Type name strings used for dynamically accessing a type should be assembly qualified. [/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/System.ComponentModel.TypeConverter.Tests.csproj]
/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/InstallerTypeAttributeTests.cs(16707566): error IL2105: System.ComponentModel.Tests.InstallerTypeAttributeTests.<Equals_TestData>d__5.MoveNext(): Type 'typeName' was not found in the caller assembly nor in the base library. Type name strings used for dynamically accessing a type should be assembly qualified. [/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/System.ComponentModel.TypeConverter.Tests.csproj]
/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/InstallerTypeAttributeTests.cs(16707566): error IL2105: System.ComponentModel.Tests.InstallerTypeAttributeTests.<Equals_TestData>d__5.MoveNext(): Type 'typeName' was not found in the caller assembly nor in the base library. Type name strings used for dynamically accessing a type should be assembly qualified. [/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/System.ComponentModel.TypeConverter.Tests.csproj]
/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/InstallerTypeAttributeTests.cs(16707566): error IL2105: System.ComponentModel.Tests.InstallerTypeAttributeTests.<Equals_TestData>d__5.MoveNext(): Type 'typeName' was not found in the caller assembly nor in the base library. Type name strings used for dynamically accessing a type should be assembly qualified. [/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/System.ComponentModel.TypeConverter.Tests.csproj]
/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/LicenseProviderAttributeTests.cs(16707566): error IL2105: System.ComponentModel.Tests.LicenseProviderAttributeTests.<Equals_TestData>d__6.MoveNext(): Type 'typeName' was not found in the caller assembly nor in the base library. Type name strings used for dynamically accessing a type should be assembly qualified. [/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/System.ComponentModel.TypeConverter.Tests.csproj]
/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/ToolboxItemAttributeTests.cs(16707566): error IL2105: System.ComponentModel.ToolboxItemAttributeTests.<Equals_TestData>d__7.MoveNext(): Type 'toolboxItemTypeName' was not found in the caller assembly nor in the base library. Type name strings used for dynamically accessing a type should be assembly qualified. [/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/System.ComponentModel.TypeConverter.Tests.csproj]
/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/ToolboxItemAttributeTests.cs(16707566): error IL2105: System.ComponentModel.ToolboxItemAttributeTests.<Equals_TestData>d__7.MoveNext(): Type 'toolboxitemtypename' was not found in the caller assembly nor in the base library. Type name strings used for dynamically accessing a type should be assembly qualified. [/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/System.ComponentModel.TypeConverter.Tests.csproj]
/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/ToolboxItemAttributeTests.cs(16707566): error IL2105: System.ComponentModel.ToolboxItemAttributeTests.<Equals_TestData>d__7.MoveNext(): Type 'toolboxItemTypeName' was not found in the caller assembly nor in the base library. Type name strings used for dynamically accessing a type should be assembly qualified. [/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/System.ComponentModel.TypeConverter.Tests.csproj]
/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/ToolboxItemAttributeTests.cs(16707566): error IL2105: System.ComponentModel.ToolboxItemAttributeTests.<Equals_TestData>d__7.MoveNext(): Type 'toolboxItemTypeName' was not found in the caller assembly nor in the base library. Type name strings used for dynamically accessing a type should be assembly qualified. [/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/System.ComponentModel.TypeConverter.Tests.csproj]
/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/LicenseProviderAttributeTests.cs(16707566): error IL2105: System.ComponentModel.Tests.LicenseProviderAttributeTests.<TypeId_TestData>d__4.MoveNext(): Type 'typeName' was not found in the caller assembly nor in the base library. Type name strings used for dynamically accessing a type should be assembly qualified. [/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/System.ComponentModel.TypeConverter.Tests.csproj]
  Optimizing assemblies for size, which may change the behavior of the app. Be sure to test after publishing. See: https://aka.ms/dotnet-illink
/Users/radical/dev/r3/.dotnet/sdk/6.0.100-preview.2.21155.3/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.ILLink.targets(59,5): error NETSDK1144: Optimizing assemblies for size failed. Optimization can be disabled by setting the PublishTrimmed property to false. [/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/System.ComponentModel.TypeConverter.Tests.csproj]
@radical radical added arch-wasm WebAssembly architecture trimming-for-aot `EnableAggressiveTrimming=true` used for running tests with AOT labels Apr 21, 2021
@ghost
Copy link

ghost commented Apr 21, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Make sure to change the trimmer descriptor filename in src/libraries/System.ComponentModel.TypeConverter/tests/System.ComponentModel.TypeConverter.Tests.csproj:
-    <TrimmerRootDescriptor Include="$(MSBuildThisFileDirectory)ILLink.Descriptor.xml" />
+    <TrimmerRootDescriptor Include="$(MSBuildThisFileDirectory)ILLink.Descriptors.xml" />
  • Build with /p:EnableAggressiveTrimming=true
  System.ComponentModel.TypeConverter.Tests -> /Users/radical/dev/r3/artifacts/bin/System.ComponentModel.TypeConverter.Tests/net6.0-Release/browser-wasm/System.ComponentModel.TypeConverter.Tests.dll
/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/AttributeProviderAttributeTests.cs(23,82): error IL2105: System.ComponentModel.Tests.AttributeProviderAttributeTests.<>c.<Ctor_NullPropertyName_ThrowsArgumentNullException>b__1_0(): Type 'typeN
ame' was not found in the caller assembly nor in the base library. Type name strings used for dynamically accessing a type should be assembly qualified. [/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/System.ComponentModel.TypeConverter.Tes
ts.csproj]
/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/ProvidePropertyAttributeTests.cs(16707566): error IL2105: System.ComponentModel.ProvidePropertyAttributeTests.<Equals_TestData>d__3.MoveNext(): Type 'receiverTypeName' was not found in the call
er assembly nor in the base library. Type name strings used for dynamically accessing a type should be assembly qualified. [/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/System.ComponentModel.TypeConverter.Tests.csproj]
/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/ProvidePropertyAttributeTests.cs(16707566): error IL2105: System.ComponentModel.ProvidePropertyAttributeTests.<Equals_TestData>d__3.MoveNext(): Type 'receiverTypeName' was not found in the call
er assembly nor in the base library. Type name strings used for dynamically accessing a type should be assembly qualified. [/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/System.ComponentModel.TypeConverter.Tests.csproj]
/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/ProvidePropertyAttributeTests.cs(16707566): error IL2105: System.ComponentModel.ProvidePropertyAttributeTests.<Equals_TestData>d__3.MoveNext(): Type 'receiverTypeName' was not found in the call
er assembly nor in the base library. Type name strings used for dynamically accessing a type should be assembly qualified. [/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/System.ComponentModel.TypeConverter.Tests.csproj]
/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/ProvidePropertyAttributeTests.cs(16707566): error IL2105: System.ComponentModel.ProvidePropertyAttributeTests.<Equals_TestData>d__3.MoveNext(): Type 'receiverTypeName' was not found in the call
er assembly nor in the base library. Type name strings used for dynamically accessing a type should be assembly qualified. [/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/System.ComponentModel.TypeConverter.Tests.csproj]
/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/ProvidePropertyAttributeTests.cs(16707566): error IL2105: System.ComponentModel.ProvidePropertyAttributeTests.<Equals_TestData>d__3.MoveNext(): Type 'receivertypename' was not found in the call
er assembly nor in the base library. Type name strings used for dynamically accessing a type should be assembly qualified. [/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/System.ComponentModel.TypeConverter.Tests.csproj]
/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/ProvidePropertyAttributeTests.cs(16707566): error IL2105: System.ComponentModel.ProvidePropertyAttributeTests.<Equals_TestData>d__3.MoveNext(): Type 'receiverTypeName' was not found in the caller assembly nor in the base library. Type name strings used for dynamically accessing a type should be assembly qualified. [/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/System.ComponentModel.TypeConverter.Tests.csproj]
/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/InstallerTypeAttributeTests.cs(16707566): error IL2105: System.ComponentModel.Tests.InstallerTypeAttributeTests.<Equals_TestData>d__5.MoveNext(): Type 'typename' was not found in the caller assembly nor in the base library. Type name strings used for dynamically accessing a type should be assembly qualified. [/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/System.ComponentModel.TypeConverter.Tests.csproj]
/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/InstallerTypeAttributeTests.cs(16707566): error IL2105: System.ComponentModel.Tests.InstallerTypeAttributeTests.<Equals_TestData>d__5.MoveNext(): Type 'typeName' was not found in the caller assembly nor in the base library. Type name strings used for dynamically accessing a type should be assembly qualified. [/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/System.ComponentModel.TypeConverter.Tests.csproj]
/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/InstallerTypeAttributeTests.cs(16707566): error IL2105: System.ComponentModel.Tests.InstallerTypeAttributeTests.<Equals_TestData>d__5.MoveNext(): Type 'typeName' was not found in the caller assembly nor in the base library. Type name strings used for dynamically accessing a type should be assembly qualified. [/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/System.ComponentModel.TypeConverter.Tests.csproj]
/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/InstallerTypeAttributeTests.cs(16707566): error IL2105: System.ComponentModel.Tests.InstallerTypeAttributeTests.<Equals_TestData>d__5.MoveNext(): Type 'typeName' was not found in the caller assembly nor in the base library. Type name strings used for dynamically accessing a type should be assembly qualified. [/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/System.ComponentModel.TypeConverter.Tests.csproj]
/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/LicenseProviderAttributeTests.cs(16707566): error IL2105: System.ComponentModel.Tests.LicenseProviderAttributeTests.<Equals_TestData>d__6.MoveNext(): Type 'typeName' was not found in the caller assembly nor in the base library. Type name strings used for dynamically accessing a type should be assembly qualified. [/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/System.ComponentModel.TypeConverter.Tests.csproj]
/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/ToolboxItemAttributeTests.cs(16707566): error IL2105: System.ComponentModel.ToolboxItemAttributeTests.<Equals_TestData>d__7.MoveNext(): Type 'toolboxItemTypeName' was not found in the caller assembly nor in the base library. Type name strings used for dynamically accessing a type should be assembly qualified. [/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/System.ComponentModel.TypeConverter.Tests.csproj]
/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/ToolboxItemAttributeTests.cs(16707566): error IL2105: System.ComponentModel.ToolboxItemAttributeTests.<Equals_TestData>d__7.MoveNext(): Type 'toolboxitemtypename' was not found in the caller assembly nor in the base library. Type name strings used for dynamically accessing a type should be assembly qualified. [/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/System.ComponentModel.TypeConverter.Tests.csproj]
/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/ToolboxItemAttributeTests.cs(16707566): error IL2105: System.ComponentModel.ToolboxItemAttributeTests.<Equals_TestData>d__7.MoveNext(): Type 'toolboxItemTypeName' was not found in the caller assembly nor in the base library. Type name strings used for dynamically accessing a type should be assembly qualified. [/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/System.ComponentModel.TypeConverter.Tests.csproj]
/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/ToolboxItemAttributeTests.cs(16707566): error IL2105: System.ComponentModel.ToolboxItemAttributeTests.<Equals_TestData>d__7.MoveNext(): Type 'toolboxItemTypeName' was not found in the caller assembly nor in the base library. Type name strings used for dynamically accessing a type should be assembly qualified. [/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/System.ComponentModel.TypeConverter.Tests.csproj]
/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/LicenseProviderAttributeTests.cs(16707566): error IL2105: System.ComponentModel.Tests.LicenseProviderAttributeTests.<TypeId_TestData>d__4.MoveNext(): Type 'typeName' was not found in the caller assembly nor in the base library. Type name strings used for dynamically accessing a type should be assembly qualified. [/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/System.ComponentModel.TypeConverter.Tests.csproj]
  Optimizing assemblies for size, which may change the behavior of the app. Be sure to test after publishing. See: https://aka.ms/dotnet-illink
/Users/radical/dev/r3/.dotnet/sdk/6.0.100-preview.2.21155.3/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.ILLink.targets(59,5): error NETSDK1144: Optimizing assemblies for size failed. Optimization can be disabled by setting the PublishTrimmed property to false. [/Users/radical/dev/r3/src/libraries/System.ComponentModel.TypeConverter/tests/System.ComponentModel.TypeConverter.Tests.csproj]
Author: radical
Assignees: -
Labels:

arch-wasm, trimming-for-aot

Milestone: -

@dotnet-issue-labeler dotnet-issue-labeler bot added area-System.ComponentModel untriaged New issue has not been triaged by the area owner labels Apr 21, 2021
@radical
Copy link
Member Author

radical commented Apr 27, 2021

closing in favor of #51602 .

@radical radical closed this as completed Apr 27, 2021
@ghost ghost locked as resolved and limited conversation to collaborators May 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.ComponentModel trimming-for-aot `EnableAggressiveTrimming=true` used for running tests with AOT untriaged New issue has not been triaged by the area owner
Projects
None yet
Development

No branches or pull requests

1 participant