Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Micro-optimizations for STJ generated source #52218

Closed
4 tasks done
layomia opened this issue May 3, 2021 · 2 comments
Closed
4 tasks done

Micro-optimizations for STJ generated source #52218

layomia opened this issue May 3, 2021 · 2 comments
Assignees
@layomia
Labels
area-System.Text.Json enhancement Product code improvement that does NOT require public API changes/additions Priority:3 Work that is nice to have source-generator Indicates an issue with a source generator feature
Milestone
Future

Comments

@layomia
Copy link
Contributor

layomia commented May 3, 2021 •
edited by eiriktsarpalis
Loading

  • Consider public option for honoring runtime-provided custom converters
  • Consider moving custom converter verification source to common helper
  • When fetching runtime-provided customers, use a dictionary lookup (rather than for-loop) when JsonSerializerOptions.Converters count > ~15
  • Make JsonSerializerContext.GetTypeInfo(Type) derived implementation based on dictionary-lookup if root-serializable type count > 64 (cf. https://github.com/dotnet/runtime/pull/81239/files#r1088396569)
@layomia layomia added this to the 6.0.0 milestone May 3, 2021
@layomia layomia self-assigned this May 3, 2021
@ghost
Copy link

ghost commented May 3, 2021

Tagging subscribers to this area: @eiriktsarpalis, @layomia
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Consider public option for honoring runtime-provided custom converters
  • Consider moving custom converter verification source to common helper
  • When fetching runtime-provided customers, use a dictionary lookup (rather than for-loop) when JsonSerializerOptions.Converters count > ~15
  • Make JsonSerializerContext.GetTypeInfo(Type) derived implementation based on dictionary-lookup if root-serializable type count > 64
Author: layomia
Assignees: layomia
Labels:

area-System.Text.Json
Milestone: 6.0.0

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label May 3, 2021
@layomia layomia removed the untriaged New issue has not been triaged by the area owner label May 3, 2021
This was referenced May 3, 2021
Closed
Merged
@layomia layomia modified the milestones: 6.0.0, 7.0.0 Jul 23, 2021
@layomia layomia added the source-generator Indicates an issue with a source generator feature label Sep 22, 2021
@eiriktsarpalis eiriktsarpalis added Priority:3 Work that is nice to have enhancement Product code improvement that does NOT require public API changes/additions labels Oct 14, 2021
@layomia layomia mentioned this issue Jan 22, 2022
Closed
16 tasks
@jeffhandley jeffhandley modified the milestones: 7.0.0, Future Apr 6, 2022
@layomia layomia mentioned this issue Oct 13, 2022
Closed
26 tasks
@eiriktsarpalis
Copy link
Member

Issues were addressed by #86526.

@ghost ghost locked as resolved and limited conversation to collaborators Jun 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@layomia layomia

Labels
area-System.Text.Json enhancement Product code improvement that does NOT require public API changes/additions Priority:3 Work that is nice to have source-generator Indicates an issue with a source generator feature
Projects
None yet
Milestone
Future
Development

No branches or pull requests
3 participants
@jeffhandley @eiriktsarpalis @layomia