Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current state of Blazor WebAssembly and the Firefox Debugger #52698

Closed
curtisy1 opened this issue May 13, 2021 · 7 comments
Closed

Current state of Blazor WebAssembly and the Firefox Debugger #52698

curtisy1 opened this issue May 13, 2021 · 7 comments
Labels
arch-wasm WebAssembly architecture area-Debugger-mono
Milestone

Comments

@curtisy1
Copy link

Transferring this question here based on my question in the mono project

To save you the long read, here's the gist of it:
As far as I can tell debugging Blazor Wasm is currently only possible in Chromium based browsers because it relies on the Chrome DevTools Protocol. Having Firefox support as well would be great since there's many people using it as a daily development driver.

Taking that into consideration I have a few questions on the current state and future plans of the Wasm debugger and its support for different browsers:

  1. Is using the Firefox debugger currently supported and I'm just missing some configuration steps to make it work?
  2. Are there any future plans to add such support if it doesn't exist already?
  3. Firefox Nightly apparently supports a limited subset of CDP. If support is not planned, maybe the existing configuration could at least be tweaked to support one flavor of Firefox?
  4. If support is not planned because of the big workload another debugger implementation would cause, are community contributions still welcome to add support for it or can I and potentially others save myself the work on this? There used to be a PR about this topic already, for reference
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label May 13, 2021
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@lambdageek lambdageek added arch-wasm WebAssembly architecture area-Debugger-mono labels May 13, 2021
@ghost
Copy link

ghost commented May 13, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Transferring this question here based on my question in the mono project

To save you the long read, here's the gist of it:
As far as I can tell debugging Blazor Wasm is currently only possible in Chromium based browsers because it relies on the Chrome DevTools Protocol. Having Firefox support as well would be great since there's many people using it as a daily development driver.

Taking that into consideration I have a few questions on the current state and future plans of the Wasm debugger and its support for different browsers:

  1. Is using the Firefox debugger currently supported and I'm just missing some configuration steps to make it work?
  2. Are there any future plans to add such support if it doesn't exist already?
  3. Firefox Nightly apparently supports a limited subset of CDP. If support is not planned, maybe the existing configuration could at least be tweaked to support one flavor of Firefox?
  4. If support is not planned because of the big workload another debugger implementation would cause, are community contributions still welcome to add support for it or can I and potentially others save myself the work on this? There used to be a PR about this topic already, for reference
Author: curtisy1
Assignees: -
Labels:

arch-wasm, area-Debugger-mono, untriaged

Milestone: -

@lewing
Copy link
Member

lewing commented May 13, 2021

Hi @curtisy1 thanks for moving the discussion here.

  1. Firefox debugging isn't currently supported, @thaystg did a prototype in mono/mono that we eventually closed because we had to prioritize the supported scenarios. The CDP based proxy works with Visual Studio, Visual Studio Code, and the built in inspector in Chrome and Edge across multiple platforms so there is a lot to test.
  2. Nothing concrete at the moment.
  3. I'm not very familiar with RDP or the subset of CDP that firefox supports but I think @thaystg is familiar with some of the details. There are also some changes underway in how the runtime interacts with the remote proxy that would make it much simpler to use with other protocols.
  4. Community contributions are absolutely welcome. The main concern I'd with landing the changes here would be around testing and maintainability but those are likely solvable.

@lewing lewing added this to the Future milestone May 13, 2021
@lewing lewing removed the untriaged New issue has not been triaged by the area owner label May 13, 2021
@sshquack
Copy link

Thanks @lewing I just wanted to pitch-in my feedback on this:

  1. Firefox been my primary browser for a long time. My current stack uses react (firefox ext), and redux (firefox ext) - both of which have great debugging capabilities with the firefox js debugger.
  2. Currently debugging in Chrome or Edge with anything more than one session (example: three concurrent users adding an item to shopping cart) gets messy fast. This requires creating completely different profiles or having incognito or multiple browsers. This is by design of chromium to share the cookies. Firefox makes this a breeze with multi-account containers since my apps have complex concurrent interactions.

As someone learning blazor, it would significantly improve my developer experience to have good blazor WASM debugging capabilities for firefox without having to juggle multiple browsers. Please consider adding support for Firefox in the future.

@lewing
Copy link
Member

lewing commented Nov 19, 2021

Some progress #61776

@Turnerj
Copy link

Turnerj commented Jan 30, 2022

Hey @lewing - the linked PR is now closed and locked (automatically) due to inactivity. Is it as simple as there isn't enough time/resources/priority to continue that right now or was something specific with the changes/direction/design of the work?

@lewing
Copy link
Member

lewing commented May 11, 2022

Thanks to a lot of work by @thaystg and help from others there is now firefox debugger support integrated into the debug proxy and tested as part of CI, any issues with that work can be opened as new issues. Closing this.

@lewing lewing closed this as completed May 11, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jun 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Debugger-mono
Projects
None yet
Development

No branches or pull requests

5 participants