-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement new FileStreamStrategy for Unix #53809
Comments
Tagging subscribers to this area: @carlossanlop Issue Detailscc @stephentoub
|
I can do it, I will start working on it in after July 2. |
@teo-tsirpanis, I hadn't seen this comment, and I was inspired to do it based on your RandomAccess PR. Have you already started? I'm fairly close to done, but if you're already working on it, I can drop mine and let you run with it. |
No @stephentoub I haven't started it yet, that was going to be after the |
I am currently working on it, its progress can be found on https://github.com/teo-tsirpanis/dotnet-runtime/tree/unix-file-stream-strategy, I will submit a PR once ready. |
Based on your previous response ("Better not drop it though"), I have a PR ready to go; I just need to measure it with your other PR. You're of course welcome to keep working on it, though... maybe you'll come up with a better solution. :-) |
OK, better you do it, both PRs are following the same idea either way but yours is already complete and you can locally test and benchmark it (spoiler alert, I could not test the other PR on my machine, it's not powerful enough and does not even have Linux 😳). And you did some things I reviewed your code and did not find anything I would change. |
#53669 (comment)
cc @stephentoub
The text was updated successfully, but these errors were encountered: