-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Perf] Regressions in System.IO.Tests.Perf_FileStream #54570
Comments
Tagging subscribers to this area: @dotnet/area-system-io Issue DetailsRun Information
Regressions in System.IO.Tests.Perf_FileStream
Reprogit clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f netcoreapp5.0 --filter 'System.IO.Tests.Perf_FileStream*' PayloadsHistogramSystem.IO.Tests.Perf_FileStream.SeekForward(fileSize: 1024, options: None)
System.IO.Tests.Perf_FileStream.SeekBackward(fileSize: 1024, options: None)
DocsProfiling workflow for dotnet/runtime repository
|
Seems likely related to #53669 |
I've taken a look at the source code and the profiles and there is very little we can do about the current implementation (my current best idea would get rid of two virtual method invocations which is not a lot). Since overall this benchmark is more than 20 times faster than .NET 5 and this method ( |
Run Information
Regressions in System.IO.Tests.Perf_FileStream
Historical Data in Reporting System
Repro
Payloads
Baseline
Compare
Histogram
System.IO.Tests.Perf_FileStream.SeekForward(fileSize: 1024, options: None)
System.IO.Tests.Perf_FileStream.SeekBackward(fileSize: 1024, options: None)
Docs
Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
The text was updated successfully, but these errors were encountered: