Hot reload doesn't work on Browser AOT

[lambdageek]

hot reload is not supported for AOTd assemblies.

Instead of disabling the test with [ActiveIssue] we need to update ApplyUpdateUtil.IsSupported to detect that we're in AOT and disable the test.

[dotnet-issue-labeler]

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

[ghost]

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

---

hot reload is not supported for AOTd assemblies.

Instead of disabling the test with [ActiveIssue] we need to update ApplyUpdateUtil.IsSupported to detect that we're in AOT and disable the test.

Author:	lambdageek
Assignees:	-
Labels:	arch-wasm, area-EnC-mono, disabled-test
Milestone:	6.0.0

[radical]

@lambdageek Should #53565 be closed in favor of this?

[lambdageek]

Oh darn, I missed that we already had an issue. I guess we should close the older one, since this one now has a reference in the code

[lewing]

@lambdageek This is listed in a couple active issues now so I tried to make the description and milestone match, feel free update.

[safern]

I just hit this test failure while adding the new runtime-extra-platforms pipeline even though the test is conditioned:

runtime/src/libraries/System.Runtime.Loader/tests/ApplyUpdateTest.cs

Line 332 in c50185b

[ConditionalFact(typeof(ApplyUpdateUtil), nameof(ApplyUpdateUtil.IsSupported))]

can someone please take a look?

Here are some files to help the investigation:

• console.log
• AOTBuild.binlog
• wasm-console.log

[radical]

This is being hit on rolling builds, log too.

[09:18:20] fail: [FAIL] System.Reflection.Metadata.ApplyUpdateTest.TestAddStaticLambda
[09:18:20] info: Assert.Equal() Failure
[09:18:20] info:               ↓ (pos 4)
[09:18:20] info: Expected: abcd1abcd
[09:18:20] info: Actual:   abcd
[09:18:20] info:               ↑ (pos 4)
[09:18:20] info:    at System.Reflection.RuntimeMethodInfo.InvokeWorker(Object , BindingFlags , Span`1 )
[09:18:20] fail: Running test using direct invoke
                 
[09:18:20] fail: Applying metadata update for System.Reflection.Metadata.ApplyUpdate.Test.CustomAttributeUpdate.dll, revision 1
                 
[09:18:20] fail: Running test using direct invoke
                 
[09:18:20] fail: Applying metadata update for System.Reflection.Metadata.ApplyUpdate.Test.AddLambdaCapturingThis.dll, revision 1
                 
[09:18:20] fail: [FAIL] System.Reflection.Metadata.ApplyUpdateTest.TestAddLambdaCapturingThis
[09:18:20] info: Assert.Equal() Failure
[09:18:20] info:           ↓ (pos 0)
[09:18:20] info: Expected: 42123abcd
[09:18:20] info: Actual:   123
[09:18:20] info:           ↑ (pos 0)
[09:18:20] info:    at System.Reflection.RuntimeMethodInfo.InvokeWorker(Object , BindingFlags , Span`1 )
[09:18:20] fail: Running test using direct invoke
                 
[09:18:20] fail: Applying metadata update for System.Reflection.Metadata.ApplyUpdate.Test.AddStaticField.dll, revision 1
                 
[09:18:20] fail: [FAIL] System.Reflection.Metadata.ApplyUpdateTest.TestAddStaticField
[09:18:20] info: Assert.Equal() Failure
[09:18:20] info:           ↓ (pos 0)
[09:18:20] info: Expected: 4567
[09:18:20] info: Actual:   abcd
[09:18:20] info:           ↑ (pos 0)
[09:18:20] info:    at System.Reflection.RuntimeMethodInfo.InvokeWorker(Object , BindingFlags , Span`1 )

[lambdageek]

@radical please disable the failing tests for AOT configurations. Hot reload is not supported for AOTd assemblies