Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System.Text.Json and ISerializable #54940

Closed
denis-dbm-inactive opened this issue Jun 30, 2021 · 2 comments
Closed

System.Text.Json and ISerializable #54940

denis-dbm-inactive opened this issue Jun 30, 2021 · 2 comments
Labels
area-System.Text.Json

Comments

@denis-dbm-inactive
Copy link

Are there plans to support ISerializable in System.Text.Json?

Newtonsoft lib does that: https://www.newtonsoft.com/json/help/html/SerializationGuide.htm#ISerializable

Thanks
@dotnet-issue-labeler dotnet-issue-labeler bot added area-System.Text.Json untriaged New issue has not been triaged by the area owner labels Jun 30, 2021
@ghost
Copy link

ghost commented Jun 30, 2021

Tagging subscribers to this area: @eiriktsarpalis, @layomia
See info in area-owners.md if you want to be subscribed.

Issue Details

Are there plans to support ISerializable in System.Text.Json?

Newtonsoft lib does that: https://www.newtonsoft.com/json/help/html/SerializationGuide.htm#ISerializable

Thanks

Author: denis-dbm
Assignees: -
Labels:

area-System.Text.Json, untriaged
Milestone: -

@eiriktsarpalis
Copy link
Member

The short answer is no. We are planning on deprecating BinaryFormatter and related types in future releases, which also includes ISerializable.

The linked document details the justification behind this decision, but TL;DR the design of BinaryFormatter (including ISerializable) contains serious security flaws, so we would never consider incorporating support in new serializers.

Related to #30083. cc @GrabYourPitchforks

@eiriktsarpalis eiriktsarpalis removed the untriaged New issue has not been triaged by the area owner label Jun 30, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Text.Json
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eiriktsarpalis @denis-dbm-inactive