Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Failures in System.Linq.Expressions.Tests.UnaryQuoteTests test suite #55067

Closed
MaximLipnin opened this issue Jul 2, 2021 · 2 comments
Closed

[iOS] Failures in System.Linq.Expressions.Tests.UnaryQuoteTests test suite #55067

MaximLipnin opened this issue Jul 2, 2021 · 2 comments
Labels
area-System.Linq.Expressions untriaged New issue has not been triaged by the area owner

Comments

@MaximLipnin
Copy link
Contributor

When trying to enable the interpretation mode for LambdaCompiler on iOS-like targets in #54970, I get the failure in System.Linq.Expressions.Tests.UnaryQuoteTest test suite like below:

Xunit.Sdk.EqualException: Assert.Equal() Failure\nExpected: MemberAccess\nActual:   Convert

The failing tests are:

  • System.Linq.Expressions.Tests.UnaryQuoteTests.Quote_Block_Closure(useInterpreter: False)
  • System.Linq.Expressions.Tests.UnaryQuoteTests.Quote_Lambda_Closure2(useInterpreter: False)
  • System.Linq.Expressions.Tests.UnaryQuoteTests.Quote_Lambda_Closure1(useInterpreter: False)
  • System.Linq.Expressions.Tests.UnaryQuoteTests.Quote_CatchBlock_Variable_Closure1(useInterpreter: False)
  • System.Linq.Expressions.Tests.UnaryQuoteTests.Quote_CatchBlock_NoVariable_Closure2(useInterpreter: False)
  • System.Linq.Expressions.Tests.UnaryQuoteTests.Quote_CatchBlock_Variable_Closure2(useInterpreter: False)
  • System.Linq.Expressions.Tests.UnaryQuoteTests.Quote_CatchBlock_NoVariable_Closure1(useInterpreter: False)
  • System.Linq.Expressions.Tests.UnaryQuoteTests.Quote_Block_LocalAndClosure(useInterpreter: False)

https://github.com/dotnet/runtime/pull/54970/checks?check_run_id=2961997278

cc @steveisok
@dotnet-issue-labeler dotnet-issue-labeler bot added area-System.Linq.Expressions untriaged New issue has not been triaged by the area owner labels Jul 2, 2021
@ghost
Copy link

ghost commented Jul 2, 2021

Tagging subscribers to this area: @cston
See info in area-owners.md if you want to be subscribed.

Issue Details

When trying to enable the interpretation mode for LambdaCompiler on iOS-like targets in #54970, I get the failure in System.Linq.Expressions.Tests.UnaryQuoteTest test suite like below:

Xunit.Sdk.EqualException: Assert.Equal() Failure\nExpected: MemberAccess\nActual:   Convert

The failing tests are:

  • System.Linq.Expressions.Tests.UnaryQuoteTests.Quote_Block_Closure(useInterpreter: False)
  • System.Linq.Expressions.Tests.UnaryQuoteTests.Quote_Lambda_Closure2(useInterpreter: False)
  • System.Linq.Expressions.Tests.UnaryQuoteTests.Quote_Lambda_Closure1(useInterpreter: False)
  • System.Linq.Expressions.Tests.UnaryQuoteTests.Quote_CatchBlock_Variable_Closure1(useInterpreter: False)
  • System.Linq.Expressions.Tests.UnaryQuoteTests.Quote_CatchBlock_NoVariable_Closure2(useInterpreter: False)
  • System.Linq.Expressions.Tests.UnaryQuoteTests.Quote_CatchBlock_Variable_Closure2(useInterpreter: False)
  • System.Linq.Expressions.Tests.UnaryQuoteTests.Quote_CatchBlock_NoVariable_Closure1(useInterpreter: False)
  • System.Linq.Expressions.Tests.UnaryQuoteTests.Quote_Block_LocalAndClosure(useInterpreter: False)

https://github.com/dotnet/runtime/pull/54970/checks?check_run_id=2961997278

cc @steveisok

Author: MaximLipnin
Assignees: -
Labels:

area-System.Linq.Expressions, untriaged
Milestone: -

@MaximLipnin
Copy link
Contributor Author

Setting <IsInterpreting Condition="'$(TargetsiOS)' == 'true' or '$(TargetstvOS)' == 'true' or '$(TargetsMacCatalyst)' == 'true'">true</IsInterpreting> in the test project file helped to address the issue, closing it.

@ghost ghost locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Linq.Expressions untriaged New issue has not been triaged by the area owner
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MaximLipnin