-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] JSObject parameters of callback from JS to managed are not released and stay inFlight #56303
Comments
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsIn my PR #54453 I introduced reference counter for objects InFlight across the JS/managed boundary. Example scenario is OnMessage callback of WebSocket. It passes Event object, which is marshaled as JSObject.
|
In my PR #54453 I introduced reference counter for objects InFlight across the JS/managed boundary.
The method
extract_mono_obj
increases the inflight refcount and it is decreased on managed side for return values.But we do not decrease refcount for JSObjects passed as parameters to callbacks.
Example scenario is OnMessage callback of WebSocket. It passes Event object, which is marshaled as JSObject.
Since the callback delegate is pointing directly to the user code, we currently don't have platform place which could decrease the inflight ref count.
The text was updated successfully, but these errors were encountered: