[Perf] Regressions in Microsoft.Extensions.DependencyInjection.GetServiceIEnumerable

[performanceautofiler]

Run Information

Architecture	x64
OS	ubuntu 18.04
Baseline	fae141227266277c4fd0979818d175e78331229a
Compare	3bd0acf30587c88a1448a51a852871e3407aff5f
Diff	Diff

Regressions in Microsoft.Extensions.DependencyInjection.GetServiceIEnumerable

Benchmark	Baseline	Test	Test/Base	Test Quality	Edge Detector	Baseline IR	Compare IR	IR Ratio	Baseline ETL	Compare ETL
Transient - Duration of single invocation	4.33 μs	5.28 μs	1.22	0.07	False

Historical Data in Reporting System

Repro

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f netcoreapp5.0 --filter 'Microsoft.Extensions.DependencyInjection.GetServiceIEnumerable*'

Payloads

Baseline
Compare

Histogram

Microsoft.Extensions.DependencyInjection.GetServiceIEnumerable.Transient

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

[ghost]

Tagging subscribers to this area: @eerhardt, @maryamariyan
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Run Information

Architecture	x64
OS	ubuntu 18.04
Baseline	fae141227266277c4fd0979818d175e78331229a
Compare	3bd0acf30587c88a1448a51a852871e3407aff5f
Diff	Diff

Regressions in Microsoft.Extensions.DependencyInjection.GetServiceIEnumerable

Benchmark	Baseline	Test	Test/Base	Test Quality	Edge Detector	Baseline IR	Compare IR	IR Ratio	Baseline ETL	Compare ETL
Transient - Duration of single invocation	4.33 μs	5.28 μs	1.22	0.07	False

Historical Data in Reporting System

Repro

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f netcoreapp5.0 --filter 'Microsoft.Extensions.DependencyInjection.GetServiceIEnumerable*'

Payloads

Baseline
Compare

Histogram

Microsoft.Extensions.DependencyInjection.GetServiceIEnumerable.Transient

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Author:	performanceautofiler[bot]
Assignees:	-
Labels:	area-Extensions-DependencyInjection, untriaged
Milestone:	-

[eerhardt]

@maryamariyan - any way this could have been caused by #56324?

[maryamariyan]

Yes. but the regression jump here is very negligible compared to the one seen from May timeframe from PR #52140

@pakrym

[maryamariyan]

Using a commit from today's main branch in dotnet/runtime (d329350),
and changing one line from

runtime/src/libraries/Microsoft.Extensions.DependencyInjection/src/ServiceProvider.cs

Line 170 in e5c0b81

_realizedServices[callSite.ImplementationType] = accessor;

to

            _realizedServices[callSite.ServiceType] = accessor;

Improves perf from

|    Method |        Mean |      Error |     StdDev |      Median |         Min |         Max |  Gen 0 | Gen 1 | Gen 2 | Allocated |
|---------- |------------:|-----------:|-----------:|------------:|------------:|------------:|-------:|------:|------:|----------:|
| Transient | 5,365.04 ns | 261.285 ns | 300.896 ns | 5,291.84 ns | 4,860.25 ns | 5,890.23 ns | 0.2751 |     - |     - |   2,184 B |

to

|    Method |      Mean |    Error |   StdDev |    Median |      Min |       Max |  Gen 0 | Gen 1 | Gen 2 | Allocated |
|---------- |----------:|---------:|---------:|----------:|---------:|----------:|-------:|------:|------:|----------:|
| Transient | 100.21 ns | 5.190 ns | 5.768 ns | 100.53 ns | 91.99 ns | 108.95 ns | 0.0437 |     - |     - |     344 B |

Steps to get numbers:

(following docs page in benchmarking-workflow-dotnet-runtime.md)

• built dotnet/runtime in release configuration
• copied over M.E.DI and M.E.DI.Abtractions locally built dlls to folder C:\CodeHub\runtime\artifacts\bin\testhost\net6.0-windows-Release-x64\shared\Microsoft.NETCore.App\6.0.0

performance\src\benchmarks\micro>dotnet run -c Release -f net6.0 --artifacts "C:\results\after" --coreRun "C:\CodeHub\runtime\artifacts\bin\testhost\net6.0-windows-Release-x64\shared\Microsoft.NETCore.App\6.0.0\CoreRun.exe" --filter Microsoft.Extensions.DependencyInjection.GetService*

Also tried running baseline commit in this issue (fae1412) for the same test and that gives the report below: (not fully building runtime but using DI and DI.Abstractions code snapshot from the baseline commt)

|    Method |     Mean |    Error |   StdDev |   Median |      Min |       Max |  Gen 0 | Gen 1 | Gen 2 | Allocated |
|---------- |---------:|---------:|---------:|---------:|---------:|----------:|-------:|------:|------:|----------:|
| Transient | 95.06 ns | 4.593 ns | 5.290 ns | 95.43 ns | 88.86 ns | 107.74 ns | 0.0435 |     - |     - |     344 B |

[eerhardt]

Fixed by #57155.