Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ARM32 floating point registers unwinding in PAL #57040

Closed
davidwrighton opened this issue Aug 8, 2021 · 5 comments · Fixed by #58915
Closed

Fix ARM32 floating point registers unwinding in PAL #57040

davidwrighton opened this issue Aug 8, 2021 · 5 comments · Fixed by #58915

Comments

@davidwrighton
Copy link
Member

davidwrighton commented Aug 8, 2021

While building issue #56522 with PR #56919 it was discovered that float registers are not properly being unwound on Linux Arm32 platforms. See PR #56919 for details on how to repro.

We should fix this before we ship 6.0 and if the fix is simple enough we may consider backport to 5.0.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Aug 8, 2021
@davidwrighton davidwrighton added this to the 6.0.0 milestone Aug 8, 2021
@davidwrighton davidwrighton added area-PAL-coreclr and removed untriaged New issue has not been triaged by the area owner labels Aug 8, 2021
@VincentBu
Copy link
Contributor

Failed again in: runtime-coreclr jitstress 20210810.2

Failed test:

CoreCLR Linux arm Checked jitstress2 @ (Ubuntu.1804.Arm32.Open)Ubuntu.1804.Armarch.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-18.04-helix-arm32v7-bfcd90a-20200121150440

- JIT/IL_Conformance/Convert/TestConvertFromIntegral/TestConvertFromIntegral.sh

Error message:

Return code:      1
Raw output file:      /root/helix/work/workitem/uploads/Reports/JIT.IL_Conformance/Convert/TestConvertFromIntegral/TestConvertFromIntegral.output.txt
Raw output:
BEGIN EXECUTION
/root/helix/work/correlation/corerun TestConvertFromIntegral.dll ''
No exception in DynamicConvertFromSystem.SingleToSystem.UInt640Opconv.ovf.u8
No exception in DynamicConvertFromSystem.SingleToSystem.UInt640Opconv.ovf.u8.un
The number of failed tests: 2
Expected: 100
Actual: 101
END EXECUTION - FAILED
Test Harness Exitcode is : 1
To run the test:

set CORE_ROOT=/root/helix/work/correlation
/root/helix/work/workitem/JIT/IL_Conformance/Convert/TestConvertFromIntegral/TestConvertFromIntegral.sh
Expected: True
Actual:   False


Stack trace
   at JIT_IL_Conformance._Convert_TestConvertFromIntegral_TestConvertFromIntegral_._Convert_TestConvertFromIntegral_TestConvertFromIntegral_sh() in JIT.IL_Conformance.XUnitWrapper.dll:token 0x6000004+0x295

@davidwrighton
Copy link
Member Author

@janvorli had some ideas on how to fix this, but wasn't able to put them together before he went on vacation. As he has dramatically more experience than others on the team in this area, I'd like to wait for him to address this problem.

@mangod9
Copy link
Member

mangod9 commented Aug 20, 2021

Is this a regression?

@davidwrighton
Copy link
Member Author

No, this isn't a regression.

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Sep 10, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Sep 10, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Oct 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants