Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP/3: SocketsHttpHandler.PlaintextStreamFilter #58089

Open
wfurt opened this issue Aug 25, 2021 · 4 comments
Open

HTTP/3: SocketsHttpHandler.PlaintextStreamFilter #58089

wfurt opened this issue Aug 25, 2021 · 4 comments
Labels
api-needs-work API needs work before it is approved, it is NOT ready for implementation area-System.Net.Http
Milestone
Future

Comments

@wfurt
Copy link
Member

wfurt commented Aug 25, 2021

This is similar to #48617 but the motivation is different. Main driver for this is ability to debug HTTP3 and anything inside like gRPC or custom application data.
While creating custom transport may be quite challenging with QUIC transport, ability to dump decrypted data should be relatively simple and completely within HttpClient scope.
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Aug 25, 2021
@ghost
Copy link

ghost commented Aug 25, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

This is similar to #48617 but the motivation is different. Main driver for this is ability to debug HTTP3 and anything inside like gRPC or custom application data.
While creating custom transport may be quite challenging with QUIC transport, ability to dump decrypted data should be relatively simple and completely within HttpClient scope.

Author: wfurt
Assignees: -
Labels:

area-System.Net.Http
Milestone: -

@geoffkizer
Copy link
Contributor

Agreed, we should just do this. We should wrap every HTTP3 request stream with a call to the PlaintextStreamFilter if specified.

@karelz karelz added this to the 7.0.0 milestone Aug 26, 2021
@karelz karelz added enhancement Product code improvement that does NOT require public API changes/additions and removed untriaged New issue has not been triaged by the area owner labels Aug 26, 2021
@karelz
Copy link
Member

karelz commented Aug 26, 2021 •
edited
Loading

Triage: Useful for diagnostics (logging unencrypted traffic) -- should happen in 7.0.

@karelz karelz added api-needs-work API needs work before it is approved, it is NOT ready for implementation and removed enhancement Product code improvement that does NOT require public API changes/additions labels Nov 23, 2021
@ManickaP
Copy link
Member

As agreed in our discussion and noted here: #64449. We decided to postpone PlaintextStreamFilter to the later release since for this to work we'd need either QuicStream abstraction or these 2 Stream issues: #43290 and #25344.
Punting to Future column for now.

@ManickaP ManickaP modified the milestones: 7.0.0, Future Jan 28, 2022
@ManickaP ManickaP removed their assignment Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api-needs-work API needs work before it is approved, it is NOT ready for implementation area-System.Net.Http
Projects
None yet
Milestone
Future
Development

No branches or pull requests
4 participants
@karelz @ManickaP @geoffkizer @wfurt