-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialization.Formatters.Tests - numerous failures with server GC #58642
Comments
Tagging subscribers to this area: @dotnet/area-system-runtime Issue DetailsTo repro:
I get lots of failures that look like:
This is not a GC test so it should not be sensitive to GC flavor.
|
How curious, do you have an idea how the GC could possibly affect this? As far as I know there's no concurrency. It's as if the ordering in a hash table changed, eg. Does this matter -- do you have a way to disable for server GC? We will likely remove BinaryFormatter tests as we obsolete it away. |
I believe this is related to #46272 (comment) where field ordering is non-deterministic. |
Tagging subscribers to this area: @dotnet/area-system-runtime Issue DetailsTo repro:
I get lots of failures that look like:
This is not a GC test so it should not be sensitive to GC flavor.
|
Tagging subscribers to this area: @dotnet/gc Issue DetailsTo repro:
I get lots of failures that look like:
This is not a GC test so it should not be sensitive to GC flavor.
|
I believe this is the correct area label, but let me know if it is not |
@dakersnar unless there was separate discussion, it's not clear to me that a GC change is expected here. apparently binary formatter relies on the ordering that reflection returns stuff, and that was not stable until #69506 The tests are owned by System.Runtime label as they test BinaryFormatter which is in System.Runtime.Serialization.Formatters -- https://github.com/dotnet/runtime/blob/main/docs/area-owners.md My guess is that these tests may well be fixed, or at least consistent, since #69506 and this issue can simply be closed. |
Tagging subscribers to this area: @dotnet/area-system-runtime Issue DetailsTo repro:
I get lots of failures that look like:
This is not a GC test so it should not be sensitive to GC flavor.
|
Noted, thanks for the explanation. I think in that case we can close this issue. |
To repro:
I get lots of failures that look like:
This is not a GC test so it should not be sensitive to GC flavor.
The text was updated successfully, but these errors were encountered: