-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider Uri .ctor to allow for paths starting with \\?\ #58712
Comments
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
Triage: @krwq is there any reason, why |
@krwq ping? |
Triage: Unclear what's customer demand, no info. Closing for now, we can reopen if there are customers asking for it. |
@karelz legacy reasons, that's what full framework did in at least configuration manager and xml and there is still lots of legacy code relying on that |
@krwq thanks for info. Given the arguments above and the fact we didn't hear from end customers about it yet since .NET Core 1.0, I am inclined to leave it closed for now and wait for feedback. If there is indeed strong demand from customers, we can change our mind in future. |
Another case reported Reading application settings in NET WinForms OOP designer fails with exception 'Invalid URI: The hostname could not be parsed" with similar root cause, but in this case we need to create Uri as it is used for subsequent calls: Lines 251 to 269 in c8654e7
@karelz could we reopen the issue and investigate? |
We could consider it post-7.0 (as it is risky change), if there are scenarios where it is highly inconvenient to not use |
In case if the runtime/src/libraries/Common/src/System/Security/IdentityHelper.cs Lines 31 to 36 in 6be8d27
the Uri is not looks essential in here and I could work around the bug but removing the \\?\ or something like that but I am not familiar with the code so not that sure what should be correct fix.
Anyway by seeing this kind of error reported again it feels like better to fix it at the root cause |
@karelz this bug affects Windows Forms out-of-process designer experience. /cc: @merriemcgaw |
@buyaa-n thanks for the info above. Can you please provide more details about how/where does the @RussKie understood from the context. Key questions I have: How does it work on .NET Framework? Is it a breaking change between .NET Core and .NET Framework? The key reason I am asking is that Due to dev availability reasons, we won't be able to implement it before Platform complete, which also increases risk significantly. That's why I am looking strongly into alternatives in 7.0 time frame. And if we decide to do it, we need all the information we can get about the scenario. |
According to https://docs.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation?tabs=cmd
Thanks for explanation, it seems Uri doesn't support |
See #58627 (comment) for context.
Would be nice if URI allowed for UNC paths such as i.e. those starting with
\\?\
- that would make it easier to make long paths scenarios to work.The text was updated successfully, but these errors were encountered: