Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JsonExtensionData in source generator fast path #58943

Open
Tracked by #77019
layomia opened this issue Sep 10, 2021 · 2 comments
Open
Tracked by #77019

Support JsonExtensionData in source generator fast path #58943

layomia opened this issue Sep 10, 2021 · 2 comments
Labels
area-System.Text.Json Cost:S Work that requires one engineer up to 1 week Priority:3 Work that is nice to have source-generator Indicates an issue with a source generator feature
Milestone

Comments

@layomia
Copy link
Contributor

layomia commented Sep 10, 2021

Per #51945 (comment) and #58912 (comment), the feature is currently not supported in fast-path serialization and the serializer falls back to a metadata-based implementation if provided/configured by the source generator.

We should target 7.0 - it is technically feasible to do this now, just a bit complex & a large diff at this stage in 6.0. Concretely, extension data properties (dictionaries) can have typeof(object) values which is a polymorphic scenario currently not supported in fast-path.

We should also consider deserialization support for this feature, alongside #55043 ("Consider fast-path deserialization logic in JSON source generator").

@layomia layomia added this to the 7.0.0 milestone Sep 10, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Sep 10, 2021
@ghost
Copy link

ghost commented Sep 10, 2021

Tagging subscribers to this area: @eiriktsarpalis, @layomia
See info in area-owners.md if you want to be subscribed.

Issue Details

Per #51945 (comment) and #58912 (comment), the feature is currently not supported and the serializer falls back to a metadata-based implementation if provided/configured by the source generator.

We should target 7.0 - it is technically feasible to do this now, just a bit complex & a large diff at this stage in 6.0. Concretely, extension data properties (dictionaries) can have typeof(object) values which is a polymorphic scenario currently not supported in fast-path.

Author: layomia
Assignees: -
Labels:

area-System.Text.Json

Milestone: 7.0.0

@layomia layomia removed the untriaged New issue has not been triaged by the area owner label Sep 10, 2021
@layomia layomia added the source-generator Indicates an issue with a source generator feature label Sep 22, 2021
@eiriktsarpalis
Copy link
Member

@layomia should his be included in the planned work epic?

@eiriktsarpalis eiriktsarpalis added Priority:3 Work that is nice to have Cost:S Work that requires one engineer up to 1 week labels Feb 7, 2022
@jeffhandley jeffhandley modified the milestones: 7.0.0, Future Apr 6, 2022
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Nov 4, 2022
@krwq krwq assigned layomia and unassigned layomia Dec 15, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Text.Json Cost:S Work that requires one engineer up to 1 week Priority:3 Work that is nice to have source-generator Indicates an issue with a source generator feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants