Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create spec/doc for JSON serialization #60178

Closed
krwq opened this issue Oct 8, 2021 · 1 comment
Closed

Create spec/doc for JSON serialization #60178

krwq opened this issue Oct 8, 2021 · 1 comment

Comments

@krwq
Copy link
Member

krwq commented Oct 8, 2021

Currently JSON serializer has 3 code paths which are distinct implementations:

  • regular path
  • fast path
  • code gen

we're finding more and more issues related to divergence in behavior.

I think it would be useful to spec out the expected behavior and define how it should work. We should also research other similar specs and existing implementations before finalizing it.

Benefits:

  • source of truth for behavior
  • possible interop with different languages
  • easier to find potential gaps and improvements
  • good place to add security considerations and notes to prevent us from accidentally going into the path of BinaryFormatter
@layomia
Copy link
Contributor

layomia commented Oct 12, 2021

Dup of dotnet/docs#26040. @tdykstra and I have started working on this.

@layomia layomia closed this as completed Oct 12, 2021
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Oct 12, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants