Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fill the mono_alc_get_ambient with right behavior #62099

Closed
srxqds opened this issue Nov 27, 2021 · 4 comments
Closed

fill the mono_alc_get_ambient with right behavior #62099

srxqds opened this issue Nov 27, 2021 · 4 comments
Labels
area-AssemblyLoader-mono
Milestone
8.0.0

Comments

@srxqds
Copy link
Contributor

srxqds commented Nov 27, 2021

I found the mono_alc_get_ambient is return Default ALC now.
I want to fix with below two steps:

  1. check CurrentContextualReflectionContext, if it has value return this.
  2. return current assemblyloadcontext which loads the assembly.

will it be right?
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Nov 27, 2021
@ghost
Copy link

ghost commented Nov 27, 2021

Tagging subscribers to this area:
See info in area-owners.md if you want to be subscribed.

Issue Details

I found the mono_alc_get_ambient is return Default ALC now.
I want to fix with below two steps:

  1. check CurrentContextualReflectionContext, if it has value return this.
  2. return current assemblyloadcontext which loads the assembly.

will it be right?

Author: srxqds
Assignees: -
Labels:

untriaged, area-AssemblyLoader-mono
Milestone: -

@srxqds srxqds mentioned this issue Jun 7, 2022
Merged
@SamMonoRT SamMonoRT removed the untriaged New issue has not been triaged by the area owner label Aug 3, 2022
@SamMonoRT SamMonoRT added this to the 8.0.0 milestone Aug 3, 2022
@srxqds
Copy link
Contributor Author

srxqds commented Apr 3, 2023

clear two get_default_jit_mm() at this pr: #84247

@SamMonoRT
Copy link
Member

Closing this old issue. Please re-open if you hit in 8.0.x-preview builds.

@ghost ghost locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-AssemblyLoader-mono
Projects
None yet
Milestone
8.0.0
Development

No branches or pull requests
3 participants
@srxqds @jkotas @SamMonoRT