Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve FMA code generation related to operand last use #62215

Open
weilinwa opened this issue Nov 30, 2021 · 4 comments
Open

Improve FMA code generation related to operand last use #62215

weilinwa opened this issue Nov 30, 2021 · 4 comments
Assignees
@kunalspathak
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone
Future

Comments

@weilinwa
Copy link
Contributor

weilinwa commented Nov 30, 2021 •
edited by BruceForstall
Loading

In current xarch FMA code generation, last use information of operands are used to guide the form selection. There are spaces left to improve the usage of this info. Please refer to the comment here.

Another issue to solve is the last use info change in between lowering phase and lsra phase cause some assert failure in lsra phase here.

category:cq
theme:codegen
skill-level:expert
cost:medium
impact:medium
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Nov 30, 2021
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@weilinwa weilinwa changed the title Just writing out my own thoughts here, I don't think there is anything that strictly needs to be done for the PR. It could instead be handled in a follow up if we thought it was beneficial. Improve FMA code generation related to operand last use Nov 30, 2021
@SingleAccretion SingleAccretion added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Dec 1, 2021
@ghost
Copy link

ghost commented Dec 1, 2021

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

In current xarch FMA code generation, last use information of operands are used to guide the form selection. There are spaces left to improve the usage of this info. Please refer to the comment here.

Another issue to solve is the last use info change in between lowering phase and lsra phase cause some assert failure in lsra phase here.

Author: weilinwa
Assignees: -
Labels:

area-CodeGen-coreclr, untriaged
Milestone: -

@JulieLeeMSFT
Copy link
Member

CC @kunalspathak @dotnet/jit-contrib.

@JulieLeeMSFT JulieLeeMSFT added needs-further-triage Issue has been initially triaged, but needs deeper consideration or reconsideration and removed untriaged New issue has not been triaged by the area owner labels Dec 2, 2021
@tannergooding tannergooding mentioned this issue Dec 4, 2021
Merged
@JulieLeeMSFT JulieLeeMSFT removed the needs-further-triage Issue has been initially triaged, but needs deeper consideration or reconsideration label Jun 8, 2022
@JulieLeeMSFT JulieLeeMSFT added this to the 8.0.0 milestone Jun 8, 2022
@JulieLeeMSFT
Copy link
Member

Moved to .NET 8 becaue .NET 7 code complete is getting close.

@kunalspathak kunalspathak modified the milestones: 8.0.0, Future Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kunalspathak kunalspathak

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
Future
Development

No branches or pull requests
4 participants
@kunalspathak @weilinwa @SingleAccretion @JulieLeeMSFT