Apply ConstantExpected attribute in runtime repo APIs as needed

[buyaa-n]

With #62436 we added a new ConstantExpectedAttribute to express that only constant value is expected for a parameter. Now we need to apply that parameter to the APIs parameters needs it. This issue is for tracking the APIs needs this attribute

As far as I know, we need to add this to the byte count parameter for the following APIs:

runtime/src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/X86/Avx2.cs

Lines 2137 to 2162 in 4427c56

	public static Vector256<short> ShiftLeftLogical(Vector256<short> value, byte count) => ShiftLeftLogical(value, count);
	/// <summary>
	/// __m256i _mm256_slli_epi16 (__m256i a, int imm8)
	/// VPSLLW ymm, ymm, imm8
	/// </summary>
	public static Vector256<ushort> ShiftLeftLogical(Vector256<ushort> value, byte count) => ShiftLeftLogical(value, count);
	/// <summary>
	/// __m256i _mm256_slli_epi32 (__m256i a, int imm8)
	/// VPSLLD ymm, ymm, imm8
	/// </summary>
	public static Vector256<int> ShiftLeftLogical(Vector256<int> value, byte count) => ShiftLeftLogical(value, count);
	/// <summary>
	/// __m256i _mm256_slli_epi32 (__m256i a, int imm8)
	/// VPSLLD ymm, ymm, imm8
	/// </summary>
	public static Vector256<uint> ShiftLeftLogical(Vector256<uint> value, byte count) => ShiftLeftLogical(value, count);
	/// <summary>
	/// __m256i _mm256_slli_epi64 (__m256i a, int imm8)
	/// VPSLLQ ymm, ymm, imm8
	/// </summary>
	public static Vector256<long> ShiftLeftLogical(Vector256<long> value, byte count) => ShiftLeftLogical(value, count);
	/// <summary>
	/// __m256i _mm256_slli_epi64 (__m256i a, int imm8)
	/// VPSLLQ ymm, ymm, imm8
	/// </summary>
	public static Vector256<ulong> ShiftLeftLogical(Vector256<ulong> value, byte count) => ShiftLeftLogical(value, count);

@GrabYourPitchforks @tannergooding please add the other APIs/parameters needs the attribute.

See @stephentoub's comment in #62436 (comment)

[dotnet-issue-labeler]

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

[ghost]

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

Issue Details

---

With #62436 we added a new ConstantExpectedAttribute to express that only constant value is expected for a parameter. Now we need to apply that parameter to the APIs parameters needs it. This issue is for tracking the APIs needs this attribute

As far as I know, we need to add this to the byte count parameter for the following APIs:

runtime/src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/X86/Avx2.cs

Lines 2137 to 2162 in 4427c56

	public static Vector256<short> ShiftLeftLogical(Vector256<short> value, byte count) => ShiftLeftLogical(value, count);
	/// <summary>
	/// __m256i _mm256_slli_epi16 (__m256i a, int imm8)
	/// VPSLLW ymm, ymm, imm8
	/// </summary>
	public static Vector256<ushort> ShiftLeftLogical(Vector256<ushort> value, byte count) => ShiftLeftLogical(value, count);
	/// <summary>
	/// __m256i _mm256_slli_epi32 (__m256i a, int imm8)
	/// VPSLLD ymm, ymm, imm8
	/// </summary>
	public static Vector256<int> ShiftLeftLogical(Vector256<int> value, byte count) => ShiftLeftLogical(value, count);
	/// <summary>
	/// __m256i _mm256_slli_epi32 (__m256i a, int imm8)
	/// VPSLLD ymm, ymm, imm8
	/// </summary>
	public static Vector256<uint> ShiftLeftLogical(Vector256<uint> value, byte count) => ShiftLeftLogical(value, count);
	/// <summary>
	/// __m256i _mm256_slli_epi64 (__m256i a, int imm8)
	/// VPSLLQ ymm, ymm, imm8
	/// </summary>
	public static Vector256<long> ShiftLeftLogical(Vector256<long> value, byte count) => ShiftLeftLogical(value, count);
	/// <summary>
	/// __m256i _mm256_slli_epi64 (__m256i a, int imm8)
	/// VPSLLQ ymm, ymm, imm8
	/// </summary>
	public static Vector256<ulong> ShiftLeftLogical(Vector256<ulong> value, byte count) => ShiftLeftLogical(value, count);

@GrabYourPitchforks @tannergooding please add the other APIs/parameters needs the attribute.

Originally posted by @stephentoub in #62436 (comment)

Author:	buyaa-n
Assignees:	-
Labels:	area-System.Runtime, untriaged
Milestone:	-

[wzchua]

If I'm not mistaken the intrinsic that has imm8 would need the attribute

[wzchua]

I have looked into this as part of testing the analyzer in dotnet/roslyn-analyzers#5766

what I have at the moment https://github.com/wzchua/runtime/commits/constantexpected

[buyaa-n]

@tannergooding please check @wzchua's commits that applying the attributes, or do you want them to raise a PR? Probably that is easier for review and discuss if needed