-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Json SourceGen tests are not running on .NET Framework #63463
Comments
Tagging subscribers to this area: @dotnet/area-system-text-json Issue DetailsThese tests are using an undefined Line 3 in 634dfa1
Line 3 in 634dfa1
We should also fix this one place in the docs that is using this incorrect property: runtime/docs/coding-guidelines/project-guidelines.md Lines 52 to 57 in 331823f
|
The change was reverted in #64108 |
These tests are using an undefined
$(NetFrameworkCurrent)
property. This means the tests aren't running on .NET Framework because this property is blank:runtime/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Unit.Tests/System.Text.Json.SourceGeneration.Unit.Tests.targets
Line 3 in 634dfa1
runtime/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/System.Text.Json.SourceGeneration.Tests.targets
Line 3 in 634dfa1
We should also fix this one place in the docs that is using this incorrect property:
runtime/docs/coding-guidelines/project-guidelines.md
Lines 52 to 57 in 331823f
The text was updated successfully, but these errors were encountered: