Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Json SourceGen tests are not running on .NET Framework #63463

Closed
eerhardt opened this issue Jan 6, 2022 · 2 comments · Fixed by #63803 or #67007
Closed

Json SourceGen tests are not running on .NET Framework #63463

eerhardt opened this issue Jan 6, 2022 · 2 comments · Fixed by #63803 or #67007
Assignees
Labels
area-System.Text.Json source-generator Indicates an issue with a source generator feature
Milestone

Comments

@eerhardt
Copy link
Member

eerhardt commented Jan 6, 2022

These tests are using an undefined $(NetFrameworkCurrent) property. This means the tests aren't running on .NET Framework because this property is blank:

<TargetFrameworks>$(NetCoreAppCurrent);$(NetFrameworkCurrent)</TargetFrameworks>

We should also fix this one place in the docs that is using this incorrect property:

All supported targets with unique windows/unix build for netcoreapp:
```
<PropertyGroup>
<TargetFrameworks>$(NetCoreAppCurrent)-windows;$(NetCoreAppCurrent)-Unix;$(NetFrameworkCurrent)</TargetFrameworks>
<PropertyGroup>
```

@ghost
Copy link

ghost commented Jan 6, 2022

Tagging subscribers to this area: @dotnet/area-system-text-json
See info in area-owners.md if you want to be subscribed.

Issue Details

These tests are using an undefined $(NetFrameworkCurrent) property. This means the tests aren't running on .NET Framework because this property is blank:

<TargetFrameworks>$(NetCoreAppCurrent);$(NetFrameworkCurrent)</TargetFrameworks>

We should also fix this one place in the docs that is using this incorrect property:

All supported targets with unique windows/unix build for netcoreapp:
```
<PropertyGroup>
<TargetFrameworks>$(NetCoreAppCurrent)-windows;$(NetCoreAppCurrent)-Unix;$(NetFrameworkCurrent)</TargetFrameworks>
<PropertyGroup>
```

Author: eerhardt
Assignees: -
Labels:

area-System.Text.Json

Milestone: -

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Jan 6, 2022
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jan 14, 2022
@eiriktsarpalis eiriktsarpalis removed the untriaged New issue has not been triaged by the area owner label Jan 17, 2022
@eiriktsarpalis eiriktsarpalis added this to the 7.0.0 milestone Jan 17, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jan 19, 2022
@jkotas
Copy link
Member

jkotas commented Jan 21, 2022

The change was reverted in #64108

@jkotas jkotas reopened this Jan 21, 2022
@layomia layomia added the source-generator Indicates an issue with a source generator feature label Jan 21, 2022
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Mar 22, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Apr 20, 2022
@ghost ghost locked as resolved and limited conversation to collaborators May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Text.Json source-generator Indicates an issue with a source generator feature
Projects
None yet
5 participants