Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emitinsBinary() in emitxarch.cpp: has some functionality that belongs to codegen #6356

Closed
sivarv opened this issue Jul 20, 2016 · 4 comments
Closed

emitinsBinary() in emitxarch.cpp: has some functionality that belongs to codegen #6356

sivarv opened this issue Jul 20, 2016 · 4 comments
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone
Future

Comments

@sivarv
Copy link
Member

sivarv commented Jul 20, 2016

We need to look at this functionality more closely and see if we can refactor to move out codegen functionality out of emitter.

category:implementation
theme:emitter
skill-level:intermediate
cost:medium
@sivarv sivarv self-assigned this Jul 20, 2016
@sivarv sivarv changed the title emitinsBinary() in emitxarch.cpp: has some functionality that is codegen like emitinsBinary() in emitxarch.cpp: has some functionality that belongs to codegen Jul 20, 2016
@sivarv
Copy link
Member Author

sivarv commented Mar 9, 2017

This requires refactoring emitInsBinary() so that the functionality that belongs to codegen gets moved there.

@sivarv sivarv assigned russellhadley and unassigned sivarv Mar 9, 2017
@AndyAyersMS
Copy link
Member

Would be nice to have some details here....

@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the Future milestone Jan 31, 2020
@BruceForstall BruceForstall added the JitUntriaged CLR JIT issues needing additional triage label Oct 28, 2020
@TIHan
Copy link
Contributor

TIHan commented Oct 5, 2022

I think this issue, #12178, describes some of these details.

I believe the thought is that emit functions should not take GenTree nodes and only be focused on emitting single instructions. gen functions are the ones that take GenTree nodes and use the emit functions for emitting the instructions.

@BruceForstall
Copy link
Member

Going to close this in favor of #12178

@BruceForstall BruceForstall removed enhancement Product code improvement that does NOT require public API changes/additions JitUntriaged CLR JIT issues needing additional triage labels Oct 30, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Nov 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
Future
Development

No branches or pull requests
6 participants
@TIHan @msftgits @russellhadley @AndyAyersMS @BruceForstall @sivarv