Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code cleanup of Vector/64/128/256 #63704

Open
tannergooding opened this issue Jan 12, 2022 · 1 comment
Open

Code cleanup of Vector/64/128/256 #63704

tannergooding opened this issue Jan 12, 2022 · 1 comment
Labels
area-System.Runtime.Intrinsics
Milestone
Future

Comments

@tannergooding
Copy link
Member

There were a few inconsistencies raised in #63414 for the Vector, Vector64, Vector128, and Vector256 code files that would be good to get cleaned up.

This includes using var when the type is "not apparent" and consistently using #if TARGET_64BIT now that the code lives in S.P.Corelib.

This is a small work item and just tracks doing it in a follow up PR.
@dotnet-issue-labeler dotnet-issue-labeler bot added area-System.Runtime.Intrinsics untriaged New issue has not been triaged by the area owner labels Jan 12, 2022
@ghost
Copy link

ghost commented Jan 12, 2022

Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics
See info in area-owners.md if you want to be subscribed.

Issue Details

There were a few inconsistencies raised in #63414 for the Vector, Vector64, Vector128, and Vector256 code files that would be good to get cleaned up.

This includes using var when the type is "not apparent" and consistently using #if TARGET_64BIT now that the code lives in S.P.Corelib.

This is a small work item and just tracks doing it in a follow up PR.

Author: tannergooding
Assignees: -
Labels:

area-System.Runtime.Intrinsics, untriaged
Milestone: -

This was referenced Jan 12, 2022
Merged
Merged
@tannergooding tannergooding removed the untriaged New issue has not been triaged by the area owner label Jul 15, 2022
@tannergooding tannergooding added this to the Future milestone Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-System.Runtime.Intrinsics
Projects
None yet
Milestone
Future
Development

No branches or pull requests
1 participant
@tannergooding