Remove CheckForOverflowUnderflow

[deeprobin]

I think this can be removed

runtime/src/libraries/Directory.Build.props

Lines 90 to 91 in 4d97cda

	<!-- We decided to keep this disabled by default: https://github.com/dotnet/runtime/issues/15152 -->
	<CheckForOverflowUnderflow>false</CheckForOverflowUnderflow>

because #15152 is closed

[dotnet-issue-labeler]

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

[ghost]

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

---

I think this can be removed

runtime/src/libraries/Directory.Build.props

Lines 90 to 91 in 4d97cda

	<!-- We decided to keep this disabled by default: https://github.com/dotnet/runtime/issues/15152 -->
	<CheckForOverflowUnderflow>false</CheckForOverflowUnderflow>

because #15152 is closed

Author:	deeprobin
Assignees:	-
Labels:	area-Infrastructure-libraries, untriaged
Milestone:	-

[safern]

Thanks, @deeprobin I think we are referencing that issue on the code as a historical context on why we disabled it globally. We tried to enable it for some time but then disabled it. The comment says we decided to keep it disabled by default, @stephentoub do you happen to know why did we decide to turn this off again?

[stephentoub]

Because we don't want it enabled. The vast majority of code expects it to be off and it would be a sheer ton of busy work to reliability find and change all the places that depend on it. And at that point, you've either cluttered up the code with lots of ifdefs to handle only having it enabled in debug, or you've added run-time cost to also have it enabled in release. We don't want any of that :)

That said, the default is false, so I'm not sure why it's needed in the Directory.Build.props, unless we're concerned about it being flipped somewhere higher up.

[safern]

Thanks, @stephentoub :).

From a quick GH search for the property that is the only place we have it set, so there is nowhere higher up flipping it on: https://github.com/dotnet/runtime/search?q=CheckForOverflowUnderflow

I think we can safely remove it.

[deeprobin]

I think we can close this issue, because #63825 was merged.

Similar cases are superseded by #63902.