-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test failure System.Text.RegularExpressions.Tests.RegexMatchTests.Match_VaryingLengthStrings_Huge #65289
Comments
Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions Issue DetailsRun: runtime-libraries-coreclr outerloop 20220213.4 Failed test:
Error message:
|
cc: @olsaarik |
I'll take a look. This looks like the state space has blown up, which the Antimirov mode should prevent. Maybe something I did has disabled it. |
I think I know why this is failing. The pattern is just a 100.000 characters long string and the behavior of that is the same in both Brzozowski and Antimirov mode: it expands to a string of 100.000 states checking for each character in turn. Moreover, each phase of matching creates its own set of 100.000 states (for the .* version, the reverse version and finally the original pattern). The out-of-memory is happening some time in the third phase of matching. The thing that changed was that now there's two arrays for transitions that get expanded whenever new states are added. This should be avoided by decoupling the capturing-tracking and traditional automata state spaces. I'll do the fix. |
Failed again in: runtime-libraries-coreclr outerloop 20220418.8 Failed test:
Error message:
|
This is a different test using a different regex engine. |
Failed again in: runtime-libraries-coreclr outerloop 20220426.3 Failed test:
Error message:
Failed test:
Error message:
|
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
@VincentBu, all of these Unicode_IgnoreCase_Tests failures should be #69406 rather than this issue. |
My bad, that issue has fell under my radar. I will work on it tomorrow to mitigate all those failures. |
@stephentoub, I leave a new comment under #69406 and hide those off-topic comments in this thread. |
Thanks |
@joperezr if the test is disabled, we can remove the blocking label right? |
Yes 😄. Removed. |
This test is only disabled on .NET Framework now, and seems to be fine on the rest of the frameworks and engines, so I'll go ahead and close this for now. |
Run: runtime-libraries-coreclr outerloop 20220213.4
Failed test:
Error message:
The text was updated successfully, but these errors were encountered: