Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NullableConverter does not flow serialization state #65522

Closed
Tracked by #63918
eiriktsarpalis opened this issue Feb 17, 2022 · 1 comment · Fixed by #65524
Closed
Tracked by #63918

NullableConverter does not flow serialization state #65522

eiriktsarpalis opened this issue Feb 17, 2022 · 1 comment · Fixed by #65524
Assignees
Milestone

Comments

@eiriktsarpalis
Copy link
Member

The System.Text.Json NullableConverter<T> incorrectly declares itself as a value converter, even though this only applies to cases where the T type uses a value converter itself. This means that nullable struct serialization does not flow serialization state correctly, which can result in async serialization not performing as expected.

@dotnet-issue-labeler dotnet-issue-labeler bot added area-System.Text.Json untriaged New issue has not been triaged by the area owner labels Feb 17, 2022
@ghost
Copy link

ghost commented Feb 17, 2022

Tagging subscribers to this area: @dotnet/area-system-text-json
See info in area-owners.md if you want to be subscribed.

Issue Details

The System.Text.Json NullableConverter<T> incorrectly declares itself as a value converter, even though this only applies to cases where the T type uses a value converter itself. This means that nullable struct serialization does not flow serialization state correctly, which can result in async serialization not performing as expected.

Author: eiriktsarpalis
Assignees: -
Labels:

area-System.Text.Json, untriaged

Milestone: -

@eiriktsarpalis eiriktsarpalis self-assigned this Feb 17, 2022
@eiriktsarpalis eiriktsarpalis removed the untriaged New issue has not been triaged by the area owner label Feb 17, 2022
@eiriktsarpalis eiriktsarpalis added this to the 7.0.0 milestone Feb 17, 2022
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Feb 17, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Feb 18, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Mar 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant