Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define RIDs for CBL-Mariner #65566

Closed
4 tasks
mthalman opened this issue Feb 18, 2022 · 10 comments
Closed
4 tasks

Define RIDs for CBL-Mariner #65566

mthalman opened this issue Feb 18, 2022 · 10 comments
Milestone

Comments

@mthalman
Copy link
Member

.NET is officially supported on CBL-Mariner but there aren't any RIDs defined for it. CBL-Mariner 1.0 has already been released and 2.0 is being release next month. RIDs should be defined for both.

Suggested RID format is cbl-mariner. Supported architectures are x64 and arm64.

This also should be backported to all versions:

  • 7.0/main
  • 6.0
  • 5.0
  • 3.1
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Feb 18, 2022
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Feb 18, 2022

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

.NET is officially supported on CBL-Mariner but there aren't any RIDs defined for it. CBL-Mariner 1.0 has already been released and 2.0 is being release next month. RIDs should be defined for both.

Suggested RID format is cbl-mariner. Supported architectures are x64 and arm64.

This also should be backported to all versions:

  • 7.0/main
  • 6.0
  • 5.0
  • 3.1
Author: mthalman
Assignees: -
Labels:

area-Meta, untriaged

Milestone: -

@am11
Copy link
Member

am11 commented Feb 18, 2022

but there aren't any RIDs defined for it

Not needing to define distro-level RID and things working out fine for everybody's use-cases is actually a sign of good and scalable ecosystem..

@mthalman
Copy link
Member Author

but there aren't any RIDs defined for it

Not needing to define distro-level RID and things working out fine for everybody's use-cases is actually a sign of good and scalable ecosystem..

It works fine now. But what happens when there are differences that need to be accounted for? From talking with @richlander, the intent is to have RIDs for all supported operating systems.

@am11
Copy link
Member

am11 commented Feb 18, 2022

what happens when there are differences that need to be accounted for?

The difference which matters in most (if not all) real-world scenarios is base platform (linux, darwin, win32 etc.), libc flavor (glibc, musl-libc, bionic-libc, posix-libc etc.) and architecture (x86, x64, arm64 etc.). The native code and its associative consumer code is usually written with run-time checks, polyfills and fallbacks. Generally, .NET developers tend to write portable code and seldom delve into OS differences, let alone distro-level (or worse, distro-version-level) distinctions.

the intent is to have RIDs for all supported operating systems.

Sure, linux-x64 and linux-arm64 RIDs are already defined in the RID graph, which apply to CBL-Mariner as well.

ps - out of ~300 linux distros, only handful of them are explicitly defined in the RID graph (json file), mostly from the .NET Core 1x era. Yet, binary tarball for linux-{arch} downloaded from https://dot.net works on most of the distros regardless of their presence in the graph. Case in point, Amazon Linux, which is also missing in the graph yet .NET is working out just fine in AWS cloud for years.

@jkotas
Copy link
Member

jkotas commented Feb 19, 2022

From talking with @richlander, the intent is to have RIDs for all supported operating systems.

We do not have agreed upon approach for adding Linux distro RIDs. For example, check the discussion in #62184 about adding RID for almalinux.

There are way too many Linux distros. We cannot scale to have RID for each for them and we have not seen many real-world cases where the Linux distro specific RIDs are actually useful.

@ghost
Copy link

ghost commented Mar 11, 2022

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

.NET is officially supported on CBL-Mariner but there aren't any RIDs defined for it. CBL-Mariner 1.0 has already been released and 2.0 is being release next month. RIDs should be defined for both.

Suggested RID format is cbl-mariner. Supported architectures are x64 and arm64.

This also should be backported to all versions:

  • 7.0/main
  • 6.0
  • 5.0
  • 3.1
Author: mthalman
Assignees: -
Labels:

area-Host, untriaged

Milestone: -

@ericstj
Copy link
Member

ericstj commented Mar 11, 2022

@richlander do we have any customers asking for this? Has anyone needed to explicitly target cbl-mariner?

I think for these brand new RIDs we should start out in the host as that's the first thing that needs to change to make them useful. The host needs to start identifying a distro with a particular RID.

@agocke
Copy link
Member

agocke commented Jun 14, 2022

I think this will likely be obsolete if we can complete #59803. I'm moving to 8.0 for evaluation in that time frame.

@agocke agocke added this to the 8.0.0 milestone Jun 14, 2022
@agocke agocke removed the untriaged New issue has not been triaged by the area owner label Jun 14, 2022
@richlander
Copy link
Member

I think Mariner can use the portable linux RID.

@agocke agocke closed this as completed Jun 26, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jul 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

No branches or pull requests

6 participants