Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review workaround for IsolatedStorageFile dependency on System.Security.Policy.Evidence #65930

Closed
jeffhandley opened this issue Feb 27, 2022 · 2 comments

Comments

@jeffhandley
Copy link
Member

Cleanup Issue-URLs in Code · Issue #63902 · dotnet/runtime identified a workaround in place and it's unclear if the backing issue that necessitated the workaround has been resolved.

https://github.com/stephentoub/runtime/blob/3ae87395f638a533f37b8e3385f6d3f199a72f4f/src/libraries/System.IO.IsolatedStorage/src/System/IO/IsolatedStorage/IsolatedStorageFile.cs#L38-L41

The workaround should be evaluated to determine if it's still necessary. With the findings, we should either update the code to remove the workaround, or the code comment to reference an open issue for tracking when we can remove the workaround.

/cc @deeprobin

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Feb 27, 2022
@ghost
Copy link

ghost commented Feb 27, 2022

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Cleanup Issue-URLs in Code · Issue #63902 · dotnet/runtime identified a workaround in place and it's unclear if the backing issue that necessitated the workaround has been resolved.

https://github.com/stephentoub/runtime/blob/3ae87395f638a533f37b8e3385f6d3f199a72f4f/src/libraries/System.IO.IsolatedStorage/src/System/IO/IsolatedStorage/IsolatedStorageFile.cs#L38-L41

The workaround should be evaluated to determine if it's still necessary. With the findings, we should either update the code to remove the workaround, or the code comment to reference an open issue for tracking when we can remove the workaround.

/cc @deeprobin

Author: jeffhandley
Assignees: -
Labels:

area-System.IO

Milestone: -

@jozkee
Copy link
Member

jozkee commented Mar 10, 2022

The comment is not a workaround, it is telling that certain API wasn't ported because Evidence is not available in current .NET.

We have decided twice in the past that this isn't a common secenario:
#28654
#18208

I think keeping the link is fine as it gives good context.

@jozkee jozkee closed this as completed Mar 10, 2022
@jozkee jozkee removed the untriaged New issue has not been triaged by the area owner label Mar 10, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Apr 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants