Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hot reload] Update test infrastructure to consume metadata update handler type ids #66513

Open
Tracked by #57365
lambdageek opened this issue Mar 11, 2022 · 0 comments
Assignees
Labels
area-EnC-mono Hot Reload for WebAssembly, iOS/Android, etc test-enhancement Improvements of test source code
Milestone

Comments

@lambdageek
Copy link
Member

lambdageek commented Mar 11, 2022

Depends on dotnet/hotreload-utils#152. For [CreateNewOnMetadataUpdate] types, we would really like to know in unit tests the ids of the new types that get generated in the deltas since the type names are going to be mangled. Once hotreload-utils are updated to serialize the type ids, we need to update ApplyUpdateUtils to read them and make them available to the tests. (And also the test .csproj needs to be updated to bundle the .handler.json files with the app).

Contributes to #57365

@lambdageek lambdageek added the area-EnC-mono Hot Reload for WebAssembly, iOS/Android, etc label Mar 11, 2022
@lambdageek lambdageek self-assigned this Mar 11, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Mar 11, 2022
@lambdageek lambdageek removed the untriaged New issue has not been triaged by the area owner label Mar 11, 2022
@marek-safar marek-safar added this to the 7.0.0 milestone Jun 1, 2022
@marek-safar marek-safar modified the milestones: 7.0.0, 8.0.0 Jul 27, 2022
@lambdageek lambdageek modified the milestones: 8.0.0, 9.0.0 Aug 4, 2023
@lambdageek lambdageek added the test-enhancement Improvements of test source code label Aug 4, 2023
@tommcdon tommcdon modified the milestones: 9.0.0, 10.0.0 Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-EnC-mono Hot Reload for WebAssembly, iOS/Android, etc test-enhancement Improvements of test source code
Projects
None yet
Development

No branches or pull requests

3 participants