Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System.Text.Json tests fail around DST time change #66555

Closed
jkotas opened this issue Mar 13, 2022 · 2 comments · Fixed by #66559
Closed

System.Text.Json tests fail around DST time change #66555

jkotas opened this issue Mar 13, 2022 · 2 comments · Fixed by #66559
Assignees
@Clockwork-Muse
Labels
area-System.Text.Json
Milestone
7.0.0

Comments

@jkotas
Copy link
Member

jkotas commented Mar 13, 2022

Failed in #66534

  Discovering: System.Text.Json.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Text.Json.Tests (found 2813 of 2871 test cases)
  Starting:    System.Text.Json.Tests (parallel test collections = on, max threads = 6)
    System.Text.Json.Serialization.Tests.ConstructorTests_Span.ClassWithPrimitives_Parameterless [FAIL]
      Assert.Equal() Failure
      Expected: 2023-03-12T02:43:11.1679350-08:00
      Actual:   2023-03-12T03:43:11.1679350-07:00
      Stack Trace:
        /_/src/libraries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.ParameterMatching.cs(401,0): at System.Text.Json.Serialization.Tests.ConstructorTests.ClassWithPrimitives_Parameterless()
        --- End of stack trace from previous location ---
    System.Text.Json.Serialization.Tests.ConstructorTests_String.ClassWithPrimitives_Parameterless [FAIL]
      Assert.Equal() Failure
      Expected: 2023-03-12T02:43:11.2332270-08:00
      Actual:   2023-03-12T03:43:11.2332270-07:00
      Stack Trace:
        /_/src/libraries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.ParameterMatching.cs(401,0): at System.Text.Json.Serialization.Tests.ConstructorTests.ClassWithPrimitives_Parameterless()
        --- End of stack trace from previous location ---
    System.Text.Json.Serialization.Tests.ConstructorTests_AsyncStream.ClassWithPrimitives [FAIL]
      Assert.Equal() Failure
      Expected: 2023-03-12T02:43:54.8463990-08:00
      Actual:   2023-03-12T03:43:54.8463990-07:00
      Stack Trace:
        /_/src/libraries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.ParameterMatching.cs(442,0): at System.Text.Json.Serialization.Tests.ConstructorTests.ClassWithPrimitives()
        --- End of stack trace from previous location ---
    System.Text.Json.Serialization.Tests.ConstructorTests_Span.ClassWithPrimitives [FAIL]
      Assert.Equal() Failure
      Expected: 2023-03-12T02:43:55.2968210-08:00
      Actual:   2023-03-12T03:43:55.2968210-07:00
      Stack Trace:
        /_/src/libraries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.ParameterMatching.cs(442,0): at System.Text.Json.Serialization.Tests.ConstructorTests.ClassWithPrimitives()
        --- End of stack trace from previous location ---
    System.Text.Json.Serialization.Tests.ConstructorTests_SyncStream.ClassWithPrimitives [FAIL]
      Assert.Equal() Failure
      Expected: 2023-03-12T02:43:55.6895020-08:00
      Actual:   2023-03-12T03:43:55.6895020-07:00
      Stack Trace:
        /_/src/libraries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.ParameterMatching.cs(442,0): at System.Text.Json.Serialization.Tests.ConstructorTests.ClassWithPrimitives()
        --- End of stack trace from previous location ---
    System.Text.Json.Serialization.Tests.ConstructorTests_SyncStream.ClassWithPrimitives_Parameterless [FAIL]
      Assert.Equal() Failure
      Expected: 2023-03-12T02:43:55.9520640-08:00
      Actual:   2023-03-12T03:43:55.9520640-07:00
      Stack Trace:
        /_/src/libraries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.ParameterMatching.cs(401,0): at System.Text.Json.Serialization.Tests.ConstructorTests.ClassWithPrimitives_Parameterless()
        --- End of stack trace from previous location ---
    System.Text.Json.Serialization.Tests.ConstructorTests_String.ClassWithPrimitives [FAIL]
      Assert.Equal() Failure
      Expected: 2023-03-12T02:43:56.6093880-08:00
      Actual:   2023-03-12T03:43:56.6093880-07:00
      Stack Trace:
        /_/src/libraries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.ParameterMatching.cs(442,0): at System.Text.Json.Serialization.Tests.ConstructorTests.ClassWithPrimitives()
        --- End of stack trace from previous location ---
    System.Text.Json.Serialization.Tests.ConstructorTests_AsyncStream.ClassWithPrimitives_Parameterless [FAIL]
      Assert.Equal() Failure
      Expected: 2023-03-12T02:43:57.3079840-08:00
      Actual:   2023-03-12T03:43:57.3079840-07:00
      Stack Trace:
        /_/src/libraries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.ParameterMatching.cs(401,0): at System.Text.Json.Serialization.Tests.ConstructorTests.ClassWithPrimitives_Parameterless()
        --- End of stack trace from previous location ---
  Finished:    System.Text.Json.Tests
=== TEST EXECUTION SUMMARY ===
   System.Text.Json.Tests  Total: 17477, Errors: 0, Failed: 8, Skipped: 0, Time: 124.877s
@dotnet-issue-labeler dotnet-issue-labeler bot added area-System.Text.Json untriaged New issue has not been triaged by the area owner labels Mar 13, 2022
@ghost
Copy link

ghost commented Mar 13, 2022

Tagging subscribers to this area: @dotnet/area-system-text-json
See info in area-owners.md if you want to be subscribed.

Issue Details

Failed in #66534

  Discovering: System.Text.Json.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Text.Json.Tests (found 2813 of 2871 test cases)
  Starting:    System.Text.Json.Tests (parallel test collections = on, max threads = 6)
    System.Text.Json.Serialization.Tests.ConstructorTests_Span.ClassWithPrimitives_Parameterless [FAIL]
      Assert.Equal() Failure
      Expected: 2023-03-12T02:43:11.1679350-08:00
      Actual:   2023-03-12T03:43:11.1679350-07:00
      Stack Trace:
        /_/src/libraries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.ParameterMatching.cs(401,0): at System.Text.Json.Serialization.Tests.ConstructorTests.ClassWithPrimitives_Parameterless()
        --- End of stack trace from previous location ---
    System.Text.Json.Serialization.Tests.ConstructorTests_String.ClassWithPrimitives_Parameterless [FAIL]
      Assert.Equal() Failure
      Expected: 2023-03-12T02:43:11.2332270-08:00
      Actual:   2023-03-12T03:43:11.2332270-07:00
      Stack Trace:
        /_/src/libraries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.ParameterMatching.cs(401,0): at System.Text.Json.Serialization.Tests.ConstructorTests.ClassWithPrimitives_Parameterless()
        --- End of stack trace from previous location ---
    System.Text.Json.Serialization.Tests.ConstructorTests_AsyncStream.ClassWithPrimitives [FAIL]
      Assert.Equal() Failure
      Expected: 2023-03-12T02:43:54.8463990-08:00
      Actual:   2023-03-12T03:43:54.8463990-07:00
      Stack Trace:
        /_/src/libraries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.ParameterMatching.cs(442,0): at System.Text.Json.Serialization.Tests.ConstructorTests.ClassWithPrimitives()
        --- End of stack trace from previous location ---
    System.Text.Json.Serialization.Tests.ConstructorTests_Span.ClassWithPrimitives [FAIL]
      Assert.Equal() Failure
      Expected: 2023-03-12T02:43:55.2968210-08:00
      Actual:   2023-03-12T03:43:55.2968210-07:00
      Stack Trace:
        /_/src/libraries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.ParameterMatching.cs(442,0): at System.Text.Json.Serialization.Tests.ConstructorTests.ClassWithPrimitives()
        --- End of stack trace from previous location ---
    System.Text.Json.Serialization.Tests.ConstructorTests_SyncStream.ClassWithPrimitives [FAIL]
      Assert.Equal() Failure
      Expected: 2023-03-12T02:43:55.6895020-08:00
      Actual:   2023-03-12T03:43:55.6895020-07:00
      Stack Trace:
        /_/src/libraries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.ParameterMatching.cs(442,0): at System.Text.Json.Serialization.Tests.ConstructorTests.ClassWithPrimitives()
        --- End of stack trace from previous location ---
    System.Text.Json.Serialization.Tests.ConstructorTests_SyncStream.ClassWithPrimitives_Parameterless [FAIL]
      Assert.Equal() Failure
      Expected: 2023-03-12T02:43:55.9520640-08:00
      Actual:   2023-03-12T03:43:55.9520640-07:00
      Stack Trace:
        /_/src/libraries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.ParameterMatching.cs(401,0): at System.Text.Json.Serialization.Tests.ConstructorTests.ClassWithPrimitives_Parameterless()
        --- End of stack trace from previous location ---
    System.Text.Json.Serialization.Tests.ConstructorTests_String.ClassWithPrimitives [FAIL]
      Assert.Equal() Failure
      Expected: 2023-03-12T02:43:56.6093880-08:00
      Actual:   2023-03-12T03:43:56.6093880-07:00
      Stack Trace:
        /_/src/libraries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.ParameterMatching.cs(442,0): at System.Text.Json.Serialization.Tests.ConstructorTests.ClassWithPrimitives()
        --- End of stack trace from previous location ---
    System.Text.Json.Serialization.Tests.ConstructorTests_AsyncStream.ClassWithPrimitives_Parameterless [FAIL]
      Assert.Equal() Failure
      Expected: 2023-03-12T02:43:57.3079840-08:00
      Actual:   2023-03-12T03:43:57.3079840-07:00
      Stack Trace:
        /_/src/libraries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.ParameterMatching.cs(401,0): at System.Text.Json.Serialization.Tests.ConstructorTests.ClassWithPrimitives_Parameterless()
        --- End of stack trace from previous location ---
  Finished:    System.Text.Json.Tests
=== TEST EXECUTION SUMMARY ===
   System.Text.Json.Tests  Total: 17477, Errors: 0, Failed: 8, Skipped: 0, Time: 124.877s
Author: jkotas
Assignees: -
Labels:

area-System.Text.Json, untriaged
Milestone: -

@jkotas jkotas mentioned this issue Mar 13, 2022
Merged
@Clockwork-Muse
Copy link
Contributor

I'm looking at this one.

@Clockwork-Muse Clockwork-Muse mentioned this issue Mar 13, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Mar 13, 2022
@eiriktsarpalis eiriktsarpalis removed the untriaged New issue has not been triaged by the area owner label Mar 14, 2022
@eiriktsarpalis eiriktsarpalis added this to the 7.0.0 milestone Mar 14, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Mar 16, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Apr 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Clockwork-Muse Clockwork-Muse

Labels
area-System.Text.Json
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Fix System.Text.Json tests affected by DST Clockwork-Muse/runtime
3 participants
@eiriktsarpalis @Clockwork-Muse @jkotas