Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optSetBlockWeights should not scale blocks that have PGO weights #66678

Open
BruceForstall opened this issue Mar 15, 2022 · 4 comments
Open

optSetBlockWeights should not scale blocks that have PGO weights #66678

BruceForstall opened this issue Mar 15, 2022 · 4 comments
Assignees
@BruceForstall
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone
Future

Comments

@BruceForstall
Copy link
Member

BruceForstall commented Mar 15, 2022 •
edited
Loading

Currently, optSetBlockWeights won't scale if the entire function has weights, but what if only some blocks have weights? Maybe it shouldn't scale then, either.

See #33658 (comment)

category:correctness
theme:profile-feedback
@BruceForstall BruceForstall added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 15, 2022
@BruceForstall BruceForstall added this to the 7.0.0 milestone Mar 15, 2022
@BruceForstall BruceForstall self-assigned this Mar 15, 2022
@ghost
Copy link

ghost commented Mar 15, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Currently, optSetBlockWeights won't scale if the entire function has weights, but what if only some blocks have weights? Maybe it shouldn't scale then, either.

See #33658 (comment)

Author: BruceForstall
Assignees: BruceForstall
Labels:

area-CodeGen-coreclr
Milestone: 7.0.0

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Mar 15, 2022
@BruceForstall BruceForstall removed the untriaged New issue has not been triaged by the area owner label Mar 15, 2022
@BruceForstall
Copy link
Member Author

cc @AndyAyersMS

@AndyAyersMS
Copy link
Member

I think this one is tricky -- if we are going to scale, we should preserve the PGO derived exit probabilities, but we lose track of those pretty quickly.

@AndyAyersMS AndyAyersMS mentioned this issue Jun 29, 2022
Closed
@AndyAyersMS
Copy link
Member

I don't see us changing this in .NET 7, so going to move it out.

@AndyAyersMS AndyAyersMS modified the milestones: 7.0.0, Future Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BruceForstall BruceForstall

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
Future
Development

No branches or pull requests
2 participants
@AndyAyersMS @BruceForstall