-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend usage of optimized JIT helpers for memcpy/memove. #6676
Comments
@lt72 What are the next steps on this? |
@russellhadley @RussKeldorph |
@russellhadley @RussKeldorph What are the next steps here? |
@gkhanna79 @lt72 Is this PAL work? Or is the idea that this is just in the JIT? I'm assuming that this is intended to fix the memcpy/memmove across the whole of the runtime. Gaurav is there need for a central place in the runtime for these methods to be defined? |
@russellhadley: your assumption is correct. When I opened the work item I intended this to be a follow up to the work Intel carried out for the JIT. |
@lt72 who is working on this? Given that there has not been any progress on this, I dont believe this would be blocking for 2.0. Should this be moved out? |
I am fine with that, but Russ & Russell should chime in since they own the execution of this work item. |
Due to lack of recent activity, this issue has been marked as a candidate for backlog cleanup. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will undo this process. This process is part of our issue cleanup automation. |
This issue will now be closed since it had been marked |
This work item is a follow up to PR dotnet/coreclr#7198 for issue #6638.
Currently memmove and memcpy are #define'd (and #undef'ed) is a few places in the code base.
Addressing all usages of memcpy/memmove may require identifying or creating a central place where to create a definition for those methods that is eventually routed to the correct implementation.
Also, addressing all individual usages should be carried out incrementally by providing adequate performance measurements.
The text was updated successfully, but these errors were encountered: