Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend usage of optimized JIT helpers for memcpy/memove. #6676

Closed
lt72 opened this issue Sep 16, 2016 · 9 comments
Closed

Extend usage of optimized JIT helpers for memcpy/memove. #6676

lt72 opened this issue Sep 16, 2016 · 9 comments
Labels
area-PAL-coreclr backlog-cleanup-candidate An inactive issue that has been marked for automated closure. enhancement Product code improvement that does NOT require public API changes/additions help wanted [up-for-grabs] Good issue for external contributors no-recent-activity optimization tenet-performance Performance related issue
Milestone

Comments

@lt72
Copy link
Contributor

lt72 commented Sep 16, 2016

This work item is a follow up to PR dotnet/coreclr#7198 for issue #6638.
Currently memmove and memcpy are #define'd (and #undef'ed) is a few places in the code base.
Addressing all usages of memcpy/memmove may require identifying or creating a central place where to create a definition for those methods that is eventually routed to the correct implementation.
Also, addressing all individual usages should be carried out incrementally by providing adequate performance measurements.

@gkhanna79
Copy link
Member

@lt72 What are the next steps on this?

@lt72
Copy link
Contributor Author

lt72 commented Jan 12, 2017

@russellhadley @RussKeldorph
I guess integrate the work Intel carried out for Clang. Addding Russ & Russell that, I believe, own such work item.

@gkhanna79
Copy link
Member

@russellhadley @RussKeldorph What are the next steps here?

@russellhadley
Copy link
Contributor

@gkhanna79 @lt72 Is this PAL work? Or is the idea that this is just in the JIT? I'm assuming that this is intended to fix the memcpy/memmove across the whole of the runtime. Gaurav is there need for a central place in the runtime for these methods to be defined?

@lt72
Copy link
Contributor Author

lt72 commented Apr 13, 2017

@russellhadley: your assumption is correct. When I opened the work item I intended this to be a follow up to the work Intel carried out for the JIT.

@gkhanna79
Copy link
Member

@lt72 who is working on this? Given that there has not been any progress on this, I dont believe this would be blocking for 2.0. Should this be moved out?

@lt72
Copy link
Contributor Author

lt72 commented May 5, 2017

I am fine with that, but Russ & Russell should chime in since they own the execution of this work item.

@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the Future milestone Jan 31, 2020
@ghost
Copy link

ghost commented Dec 23, 2022

Due to lack of recent activity, this issue has been marked as a candidate for backlog cleanup. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will undo this process.

This process is part of our issue cleanup automation.

@ghost ghost added backlog-cleanup-candidate An inactive issue that has been marked for automated closure. no-recent-activity labels Dec 23, 2022
@ghost
Copy link

ghost commented Jan 6, 2023

This issue will now be closed since it had been marked no-recent-activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the issue, but please note that the issue will be locked if it remains inactive for another 30 days.

@ghost ghost closed this as completed Jan 6, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Feb 5, 2023
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-PAL-coreclr backlog-cleanup-candidate An inactive issue that has been marked for automated closure. enhancement Product code improvement that does NOT require public API changes/additions help wanted [up-for-grabs] Good issue for external contributors no-recent-activity optimization tenet-performance Performance related issue
Projects
None yet
Development

No branches or pull requests

5 participants