Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RyuJIT x86: allow long-typed struct fields to be recursively promoted #6707

Closed
pgavlin opened this issue Sep 22, 2016 · 0 comments · Fixed by #88090
Closed

RyuJIT x86: allow long-typed struct fields to be recursively promoted #6707

pgavlin opened this issue Sep 22, 2016 · 0 comments · Fixed by #88090
Assignees
@jakobbotsch
Labels
arch-x86 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI enhancement Product code improvement that does NOT require public API changes/additions optimization Priority:2 Work that is important, but not critical for the release tenet-performance Performance related issue
Milestone
8.0.0

Comments

@pgavlin
Copy link
Contributor

pgavlin commented Sep 22, 2016 •
edited by BruceForstall
Loading

RyuJIT is currently unable to recursively promote fields of promoted struct vars. When targeting x86, this restriction causes representational issues for structs that have long-typed fields: normally, we would promote the variables that represent these fields, allowing them to be enregistered. Because we cannot perform the necessary recursive promotion, the variables that represent these long-typed fields are forced onto the stack.

category:cq
theme:structs
skill-level:expert
cost:medium
impact:medium
@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the Future milestone Jan 31, 2020
@erozenfeld erozenfeld mentioned this issue Jun 5, 2020
Closed
@jakobbotsch jakobbotsch mentioned this issue Dec 15, 2022
Closed
40 tasks
@jakobbotsch jakobbotsch self-assigned this Jun 16, 2023
@jakobbotsch jakobbotsch modified the milestones: Future, 8.0.0 Jun 16, 2023
@jakobbotsch jakobbotsch added the Priority:2 Work that is important, but not critical for the release label Jun 20, 2023
@jakobbotsch jakobbotsch mentioned this issue Jun 27, 2023
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jun 27, 2023
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jun 29, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jul 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jakobbotsch jakobbotsch

Labels
arch-x86 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI enhancement Product code improvement that does NOT require public API changes/additions optimization Priority:2 Work that is important, but not critical for the release tenet-performance Performance related issue
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

JIT: Enable physical promotion by default jakobbotsch/runtime
3 participants
@pgavlin @jakobbotsch @msftgits