Fix System.Text.Json source code annotation RequiresUnreferencedCodeAttribute by moving it to class level

[LakshanF]

Description

As mentioned in this comment, there is a desire to revisit some source in the annotation in System.Text.Json namespace to hoist it to class level once issue is fixed. Its done now.

Reproduction Steps

No observable behavioral change with the issue but only impacts code hygiene

Expected behavior

RequiresUnreferencedCodeAttribute to be moved up to the class header

Actual behavior

RequiresUnreferencedCodeAttribute is at many members in the class

Regression?

No

Known Workarounds

No response

Configuration

No response

Other information

No response

[ghost]

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Description

As mentioned in this comment, there is a desire to revisit some source in the annotation in System.Text.Json namespace to hoist it to class level once issue is fixed. Its done now.

Reproduction Steps

No observable behavioral change with the issue but only impacts code hygiene

Expected behavior

RequiresUnreferencedCodeAttribute to be moved up to the class header

Actual behavior

RequiresUnreferencedCodeAttribute is at many members in the class

Regression?

No

Known Workarounds

No response

Configuration

No response

Other information

No response

Author:	LakshanF
Assignees:	-
Labels:	area-System.Text.Json, untriaged
Milestone:	-

[ghost]

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Description

As mentioned in this comment, there is a desire to revisit some source in the annotation in System.Text.Json namespace to hoist it to class level once issue is fixed. Its done now.

Reproduction Steps

No observable behavioral change with the issue but only impacts code hygiene

Expected behavior

RequiresUnreferencedCodeAttribute to be moved up to the class header

Actual behavior

RequiresUnreferencedCodeAttribute is at many members in the class

Regression?

No

Known Workarounds

No response

Configuration

No response

Other information

No response

Author:	LakshanF
Assignees:	-
Labels:	enhancement, area-System.Text.Json, untriaged, linkable-framework
Milestone:	-

[eiriktsarpalis]

I previously attempted making that change, but it turned out that adding RUC annotations on the type level introduced other complications, for example it was triggering linker warnings when consuming const or static members on that class even though it shouldn't.

Keeping the annotations on the constructors should be fine until annotation issues have been ironed out, so I don't think we need to track this via an open issue. I'm going to close this.

[vitek-karas]

for example it was triggering linker warnings when consuming const or static members on that class even though it shouldn't.

This is by design - putting the RUC on class means that everything about the class is dangerous. It is functionally equivalent to

• putting RUC on all .ctors
• putting RUC on all static methods and fields

If the class is only dangerous when instantiated, then you should put RUC on .ctors alone.