Bad Process.StartTime in .NET 6 on Android #67583

AigioL · 2022-04-05T12:46:04Z

Description

System.Diagnostics.Process.StartTime throws an exception on net6.0-android, but works fine on Xamarin.Android

Reproduction Steps

https://github.com/BeyondDimension/AspNetCore.Mobile/blob/refs/tags/test-process-starttime/src/AspNetCore.Mobile.Droid/MainActivity.cs#L50-L63

void TestProcessStartTime()
{
    string startTimeString;
    try
    {
        var p = global::System.Diagnostics.Process.GetCurrentProcess();
        startTimeString = p.StartTime.ToString();
    }
    catch (Exception e)
    {
        startTimeString = e.ToString();
    }
    WriteLine($"StartTime: {startTimeString}");
}

Expected behavior

Returns the correct DateTime

Actual behavior

 android.runtime.JavaProxyThrowable: System.UnauthorizedAccessException: Access to the path '/proc/stat' is denied.
     ---> System.IO.IOException: Permission denied
       --- End of inner exception stack trace ---
        at Interop.ThrowExceptionForIoErrno(ErrorInfo errorInfo, String path, Boolean isDirectory, Func`2 errorRewriter)
        at Interop.CheckIo(Error error, String path, Boolean isDirectory, Func`2 errorRewriter)
        at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String path, OpenFlags flags, Int32 mode)
        at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String fullPath, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize)
        at System.IO.Strategies.OSFileStreamStrategy..ctor(String path, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize)
        at System.IO.Strategies.UnixFileStreamStrategy..ctor(String path, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize)
        at System.IO.Strategies.FileStreamHelpers.ChooseStrategyCore(String path, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize)
        at System.IO.Strategies.FileStreamHelpers.ChooseStrategy(FileStream fileStream, String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options, Int64 preallocationSize)
        at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options, Int64 preallocationSize)
        at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options)
        at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, Boolean useAsync)
        at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize)
        at System.IO.StreamReader.ValidateArgsAndOpenPath(String path, Encoding encoding, Int32 bufferSize)
        at System.IO.StreamReader..ctor(String path, Encoding encoding, Boolean detectEncodingFromByteOrderMarks, Int32 bufferSize)
        at System.IO.StreamReader..ctor(String path, Encoding encoding, Boolean detectEncodingFromByteOrderMarks)
        at System.IO.File.InternalReadAllText(String path, Encoding encoding)
        at System.IO.File.ReadAllText(String path)
        at System.Diagnostics.Process.get_BootTime()
        at System.Diagnostics.Process.BootTimeToDateTime(TimeSpan timespanAfterBoot)
        at System.Diagnostics.Process.get_StartTimeCore()
        at System.Diagnostics.Process.get_StartTime()

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

This is the compiled apk files

Xamarin.Android 12 APK

NET 6.0 APK

The text was updated successfully, but these errors were encountered:

dotnet-issue-labeler · 2022-04-05T12:46:07Z

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

ghost · 2022-04-05T12:57:44Z

Tagging subscribers to this area: @dotnet/area-system-diagnostics-process
See info in area-owners.md if you want to be subscribed.

Issue Details

Description

System.Diagnostics.Process.StartTime throws an exception on net6.0-android, but works fine on Xamarin.Android

Reproduction Steps

https://github.com/BeyondDimension/AspNetCore.Mobile/blob/refs/tags/test-process-starttime/src/AspNetCore.Mobile.Droid/MainActivity.cs#L50-L63

void TestProcessStartTime()
{
    string startTimeString;
    try
    {
        var p = global::System.Diagnostics.Process.GetCurrentProcess();
        startTimeString = p.StartTime.ToString();
    }
    catch (Exception e)
    {
        startTimeString = e.ToString();
    }
    WriteLine($"StartTime: {startTimeString}");
}

Expected behavior

Returns the correct DateTime

Actual behavior

 android.runtime.JavaProxyThrowable: System.UnauthorizedAccessException: Access to the path '/proc/stat' is denied.
     ---> System.IO.IOException: Permission denied
       --- End of inner exception stack trace ---
        at Interop.ThrowExceptionForIoErrno(ErrorInfo errorInfo, String path, Boolean isDirectory, Func`2 errorRewriter)
        at Interop.CheckIo(Error error, String path, Boolean isDirectory, Func`2 errorRewriter)
        at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String path, OpenFlags flags, Int32 mode)
        at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String fullPath, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize)
        at System.IO.Strategies.OSFileStreamStrategy..ctor(String path, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize)
        at System.IO.Strategies.UnixFileStreamStrategy..ctor(String path, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize)
        at System.IO.Strategies.FileStreamHelpers.ChooseStrategyCore(String path, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize)
        at System.IO.Strategies.FileStreamHelpers.ChooseStrategy(FileStream fileStream, String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options, Int64 preallocationSize)
        at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options, Int64 preallocationSize)
        at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options)
        at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, Boolean useAsync)
        at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize)
        at System.IO.StreamReader.ValidateArgsAndOpenPath(String path, Encoding encoding, Int32 bufferSize)
        at System.IO.StreamReader..ctor(String path, Encoding encoding, Boolean detectEncodingFromByteOrderMarks, Int32 bufferSize)
        at System.IO.StreamReader..ctor(String path, Encoding encoding, Boolean detectEncodingFromByteOrderMarks)
        at System.IO.File.InternalReadAllText(String path, Encoding encoding)
        at System.IO.File.ReadAllText(String path)
        at System.Diagnostics.Process.get_BootTime()
        at System.Diagnostics.Process.BootTimeToDateTime(TimeSpan timespanAfterBoot)
        at System.Diagnostics.Process.get_StartTimeCore()
        at System.Diagnostics.Process.get_StartTime()

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

This is the compiled apk files

Xamarin.Android 12 APK

NET 6.0 APK

Author:	AigioL
Assignees:	-
Labels:	`area-System.Diagnostics.Process`, `os-android`, `untriaged`
Milestone:	-

steveisok · 2022-07-18T15:15:06Z

@am11 Do you think you'll have time to fix this?

am11 · 2022-07-19T07:47:26Z

@steveisok, thanks for the ping. #67589 needs device testing on Android. I tried to setup an emulator last month, but it was having some issues and I got distracted by other stuff. Is there any readymade docker or emulator setup available which I can pull and use without spending time on environment setup?

Otherwise, if someone has the dev device and spare cycles to help, we need to debug this (standalone) C code and compare with Linux desktop to find out which API behaves differently on Android, and what is the minimal change that could be applied to it to get the ball rolling:

#include <assert.h>
#include <stdio.h>
#include <time.h>
#include <inttypes.h>

#define TARGET_LINUX

enum
{
    MicroSecondsToNanoSeconds = 1000,   // 10^3
    SecondsToNanoSeconds = 1000000000,  // 10^9
    SecondsToTicks = 10000000,          // 10^7
    TicksToNanoSeconds = 100,           // 10^2
};

int64_t SystemNative_GetBootTimeTicks()
{
#ifdef TARGET_LINUX
    struct timespec ts;

    int result = clock_gettime(CLOCK_BOOTTIME, &ts);
    assert(result == 0); // only possible errors are if the given clockId isn't supported or &ts is an invalid address
    (void)result; // suppress unused parameter warning in release builds

    int64_t sinceBootTicks = (ts.tv_sec * SecondsToTicks) + (ts.tv_nsec / TicksToNanoSeconds);

    result = clock_gettime(CLOCK_REALTIME_COARSE, &ts);
    assert(result == 0);

    int64_t sinceEpochTicks = (ts.tv_sec * SecondsToTicks) + (ts.tv_nsec / TicksToNanoSeconds);

    return sinceEpochTicks - sinceBootTicks;
#else
    return -1;
#endif
}


int main() {
    printf("%" PRId64 "\n", SystemNative_GetBootTimeTicks());
    return 0;
}

(SystemNative_GetBootTimeTicks is the current state of that function in PR)

adamsitnik · 2022-07-27T16:57:01Z

thanks for the ping. #67589 needs device testing on Android. I

@steveisok is there any chance you could help @am11 with the Android debugging?

danmoseley · 2022-08-05T20:53:32Z

@steveisok ?

danmoseley · 2022-09-06T02:18:04Z

@steveisok 🙂

steveisok · 2022-09-06T02:19:24Z

Sorry, yes, we can help with this one.

steveisok · 2022-09-06T19:10:02Z

@simonrozsival can you please help out with this one?

simonrozsival · 2022-09-07T13:49:30Z

@am11 I tested the code on my device with API 32 and on emulators with API 21 and 24 and it worked well on all of these levels. It seems to me that the only problem with the PR is that you're checking TARGET_LINUX and not TARGET_ANDROID.

adamsitnik · 2022-09-08T12:17:38Z

@simonrozsival thank you for your help!

dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Apr 5, 2022

am11 added area-System.Diagnostics.Process os-android labels Apr 5, 2022

am11 removed the untriaged New issue has not been triaged by the area owner label Apr 5, 2022

am11 mentioned this issue Apr 5, 2022

Use CLOCK_BOOTTIME to calculate BootTime on linux #67589

Merged

ghost added the in-pr There is an active PR which will close this issue when it is merged label Apr 5, 2022

adamsitnik assigned am11 Apr 6, 2022

ghost added in-pr There is an active PR which will close this issue when it is merged and removed in-pr There is an active PR which will close this issue when it is merged labels Apr 11, 2022

AigioL mentioned this issue Apr 22, 2022

fix RuntimeMadness.ProcessStartTime on Xamarin.Android & net6.0-android JustArchiNET/Madness#22

Closed

steveisok added this to the 8.0.0 milestone Jul 25, 2022

steveisok assigned simonrozsival Sep 6, 2022

adamsitnik closed this as completed in #67589 Sep 8, 2022

ghost removed the in-pr There is an active PR which will close this issue when it is merged label Sep 8, 2022

ghost locked as resolved and limited conversation to collaborators Oct 8, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bad Process.StartTime in .NET 6 on Android #67583

Bad Process.StartTime in .NET 6 on Android #67583

AigioL commented Apr 5, 2022 •

edited

Loading

dotnet-issue-labeler bot commented Apr 5, 2022

ghost commented Apr 5, 2022

Description

Reproduction Steps

Expected behavior

Actual behavior

Regression?

Known Workarounds

Configuration

Other information

steveisok commented Jul 18, 2022

am11 commented Jul 19, 2022

adamsitnik commented Jul 27, 2022 •

edited

Loading

danmoseley commented Aug 5, 2022

danmoseley commented Sep 6, 2022

steveisok commented Sep 6, 2022

steveisok commented Sep 6, 2022

simonrozsival commented Sep 7, 2022

adamsitnik commented Sep 8, 2022

Bad Process.StartTime in .NET 6 on Android #67583

Bad Process.StartTime in .NET 6 on Android #67583

Comments

AigioL commented Apr 5, 2022 • edited Loading

Description

Reproduction Steps

Expected behavior

Actual behavior

Regression?

Known Workarounds

Configuration

Other information

dotnet-issue-labeler bot commented Apr 5, 2022

ghost commented Apr 5, 2022

Description

Reproduction Steps

Expected behavior

Actual behavior

Regression?

Known Workarounds

Configuration

Other information

steveisok commented Jul 18, 2022

am11 commented Jul 19, 2022

adamsitnik commented Jul 27, 2022 • edited Loading

danmoseley commented Aug 5, 2022

danmoseley commented Sep 6, 2022

steveisok commented Sep 6, 2022

steveisok commented Sep 6, 2022

simonrozsival commented Sep 7, 2022

adamsitnik commented Sep 8, 2022

AigioL commented Apr 5, 2022 •

edited

Loading

adamsitnik commented Jul 27, 2022 •

edited

Loading