OSR variants may not report pinned locals as pinned

[jakobbotsch]

Description

See here: #66983 (comment)

Reproduction Steps

Trigger OSR inside the loops in System.Globalization.CompareInfo.IndexOfOrdinalHelper.

Expected behavior

The OSR variant keeps pinning variables that were pinned in tier-0.

Actual behavior

The OSR variant does not report these locals as pinned anymore.

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

No response

[dotnet-issue-labeler]

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

[ghost]

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Description

See here: #66983 (comment)

Reproduction Steps

Trigger OSR inside the loops in System.Globalization.CompareInfo.IndexOfOrdinalHelper.

Expected behavior

The OSR variant keeps pinning variables that were pinned in tier-0.

Actual behavior

The OSR variant does not report these locals as pinned anymore.

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

No response

Author:	jakobbotsch
Assignees:	-
Labels:	area-CodeGen-coreclr, untriaged
Milestone:	-

[AndyAyersMS]

Thanks. Looks like what I suspected, the OSR method sees the locals as pinned but also unreferenced... I think we just need to add an implicit reference.

;* V06 loc0         [V06    ] (  0,  0   )    long  ->  zero-ref   
;* V07 loc1         [V07    ] (  0,  0   )   byref  ->  zero-ref    pinned
;* V08 loc2         [V08    ] (  0,  0   )    long  ->  zero-ref   
;* V09 loc3         [V09    ] (  0,  0   )   byref  ->  zero-ref    pinned