Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow-up work for PartitionedRateLimiter #68776

Open
1 of 3 tasks
BrennanConroy opened this issue May 2, 2022 · 4 comments
Open
1 of 3 tasks

Follow-up work for PartitionedRateLimiter #68776

BrennanConroy opened this issue May 2, 2022 · 4 comments
Assignees
@BrennanConroy
Labels
area-System.Threading
Milestone
Future

Comments

@BrennanConroy
Copy link
Member

BrennanConroy commented May 2, 2022 •
edited
Loading

This issue is tracking follow up work from the initial implementation of PartitionedRateLimiter in #67677.

  • Figure out what interval to use for the internal Timer
    • Dynamically change it based on the intervals of the replenishing limiters?
    • Come up with some "good enough" default
    • Make it an option that the user must configure?
  • Background exceptions are currently ignored and not visible to users
    • Check what other libraries like HttpClient do
    • Maybe ExceptionDispatchInfo.Capture and dispatch throwing to the threadpool so it's at least an unhandled exception
  • Start using IdleDuration to cleanup internal dictionary when limiters aren't active
    • Probably don't want to immediately remove limiters when they become idle, likely should wait 10 seconds or something
@BrennanConroy BrennanConroy added this to the 7.0.0 milestone May 2, 2022
@BrennanConroy BrennanConroy self-assigned this May 2, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label May 2, 2022
@ghost
Copy link

ghost commented May 2, 2022

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Issue Details

This issue is tracking follow up work from the initial implementation of PartitionedRateLimiter in #67677.

  • Figure out what interval to use for the internal Timer
    • Dynamically change it based on the intervals of the replenishing limiters?
    • Come up with some "good enough" default
    • Make it an option that the user must configure?
  • Background exceptions are currently ignored and not visible to users
    • Check what other libraries like HttpClient do
    • Maybe ExceptionDispatchInfo.Capture and dispatch throwing to the threadpool so it's at least an unhandled exception
  • Start using IdleDuration to cleanup internal dictionary when limiters aren't active
    • Probably don't want to immediately remove limiters when they become idle, likely should wait 10 seconds or something
Author: BrennanConroy
Assignees: BrennanConroy
Labels:

area-System.Threading
Milestone: 7.0.0

@jeffschwMSFT jeffschwMSFT removed the untriaged New issue has not been triaged by the area owner label May 10, 2022
@BrennanConroy BrennanConroy mentioned this issue May 23, 2022
Merged
@mangod9
Copy link
Member

mangod9 commented Aug 5, 2022

since this is tagged under system.threading, checking whether any of this work is still meant for 7?

@mangod9
Copy link
Member

mangod9 commented Aug 23, 2022

ok to close this out since its still tagged for 7?

@BrennanConroy BrennanConroy modified the milestones: 7.0.0, 8.0.0 Aug 23, 2022
@mangod9
Copy link
Member

mangod9 commented Jul 13, 2023

checking if this is still being looked into for 8?

@mangod9 mangod9 modified the milestones: 8.0.0, Future Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrennanConroy BrennanConroy

Labels
area-System.Threading
Projects
None yet
Milestone
Future
Development

No branches or pull requests
3 participants
@BrennanConroy @jeffschwMSFT @mangod9