Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System.IO.FileStream.Lock ApiCompat issues #68939

Closed
jozkee opened this issue May 5, 2022 · 2 comments · Fixed by #68941
Closed

System.IO.FileStream.Lock ApiCompat issues #68939

jozkee opened this issue May 5, 2022 · 2 comments · Fixed by #68941
Assignees
@jozkee
Labels
area-System.IO blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms'

Comments

@jozkee
Copy link
Member

jozkee commented May 5, 2022 •
edited by net-helix bot
Loading

Related to #68908. I can see multiple PRs with CI reporting this error as well.
I'm just not sure if a CompatibilitySuppresions.xml is what may fix this error (considering that this is S.P.CoreLib code).

ApiCompat -> Comparing net7.0 reference assemblies against .NETStandard2.x and .NETCoreApp6.0...
C:\repos\runtime2\src\libraries\apicompat\ApiCompat.proj(82,5): error : Compat issues with assembly mscorlib:
C:\repos\runtime2\src\libraries\apicompat\ApiCompat.proj(82,5): error : CannotChangeAttribute : Attribute 'System.Runtime.Versioning.UnsupportedOSPlatformAttribute' on 'System.IO.FileStream.Lock(System.Int64, System.Int64)' changed from '[UnsupportedOSPlatformAttribute("ios")]' in the contract to '[UnsupportedOSPlatformAttribute("freebsd")]' in the implementation.
C:\repos\runtime2\src\libraries\apicompat\ApiCompat.proj(82,5): error : CannotChangeAttribute : Attribute 'System.Runtime.Versioning.UnsupportedOSPlatformAttribute' on 'System.IO.FileStream.Unlock(System.Int64, System.Int64)' changed from '[UnsupportedOSPlatformAttribute("ios")]' in the contract to '[UnsupportedOSPlatformAttribute("freebsd")]' in the implementation.
C:\repos\runtime2\src\libraries\apicompat\ApiCompat.proj(82,5): error : Compat issues with assembly netstandard:
C:\repos\runtime2\src\libraries\apicompat\ApiCompat.proj(82,5): error : CannotChangeAttribute : Attribute 'System.Runtime.Versioning.UnsupportedOSPlatformAttribute' on 'System.IO.FileStream.Lock(System.Int64, System.Int64)' changed from '[UnsupportedOSPlatformAttribute("ios")]' in the contract to '[UnsupportedOSPlatformAttribute("freebsd")]' in the implementation.
C:\repos\runtime2\src\libraries\apicompat\ApiCompat.proj(82,5): error : CannotChangeAttribute : Attribute 'System.Runtime.Versioning.UnsupportedOSPlatformAttribute' on 'System.IO.FileStream.Unlock(System.Int64, System.Int64)' changed from '[UnsupportedOSPlatformAttribute("ios")]' in the contract to '[UnsupportedOSPlatformAttribute("freebsd")]' in the implementation.
C:\repos\runtime2\src\libraries\apicompat\ApiCompat.proj(82,5): error : Compat issues with assembly System.IO.FileSystem:
C:\repos\runtime2\src\libraries\apicompat\ApiCompat.proj(82,5): error : CannotChangeAttribute : Attribute 'System.Runtime.Versioning.UnsupportedOSPlatformAttribute' on 'System.IO.FileStream.Lock(System.Int64, System.Int64)' changed from '[UnsupportedOSPlatformAttribute("ios")]' in the contract to '[UnsupportedOSPlatformAttribute("freebsd")]' in the implementation.
C:\repos\runtime2\src\libraries\apicompat\ApiCompat.proj(82,5): error : CannotChangeAttribute : Attribute 'System.Runtime.Versioning.UnsupportedOSPlatformAttribute' on 'System.IO.FileStream.Unlock(System.Int64, System.Int64)' changed from '[UnsupportedOSPlatformAttribute("ios")]' in the contract to '[UnsupportedOSPlatformAttribute("freebsd")]' in the implementation.
C:\repos\runtime2\src\libraries\apicompat\ApiCompat.proj(82,5): error : Compat issues with assembly System.Runtime:
C:\repos\runtime2\src\libraries\apicompat\ApiCompat.proj(82,5): error : CannotChangeAttribute : Attribute 'System.Runtime.Versioning.UnsupportedOSPlatformAttribute' on 'System.IO.FileStream.Lock(System.Int64, System.Int64)' changed from '[UnsupportedOSPlatformAttribute("ios")]' in the contract to '[UnsupportedOSPlatformAttribute("freebsd")]' in the implementation.
C:\repos\runtime2\src\libraries\apicompat\ApiCompat.proj(82,5): error : CannotChangeAttribute : Attribute 'System.Runtime.Versioning.UnsupportedOSPlatformAttribute' on 'System.IO.FileStream.Unlock(System.Int64, System.Int64)' changed from '[UnsupportedOSPlatformAttribute("ios")]' in the contract to '[UnsupportedOSPlatformAttribute("freebsd")]' in the implementation.

{ "ErrorMessage":"error : CannotChangeAttribute : Attribute 'System.Runtime.Versioning.UnsupportedOSPlatformAttribute' on 'System.IO.FileStream.Lock(System.Int64, System.Int64)' changed from '[UnsupportedOSPlatformAttribute(\"ios\")]' in the contract to '[UnsupportedOSPlatformAttribute(\"freebsd\")]' in the implementation." }

Report

Build Definition Step Name Console log
1755080 dotnet/runtime Build product https://dev.azure.com/dnceng/9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_apis/build/builds/1755080/logs/450
1755031 dotnet/runtime Build product https://dev.azure.com/dnceng/9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_apis/build/builds/1755031/logs/400
1755052 dotnet/runtime Build product https://dev.azure.com/dnceng/9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_apis/build/builds/1755052/logs/476

Summary

Day Hit Count Week Hit Count Month Hit Count
0 3 3
@jozkee jozkee added this to the 7.0.0 milestone May 5, 2022
@jozkee jozkee self-assigned this May 5, 2022
@ghost
Copy link

ghost commented May 5, 2022

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Related to #68908. I can see multiple PRs with CI reporting this error as well.
I'm just not sure if a CompatibilitySuppresions.xml is what may fix this error (considering that this is S.P.CoreLib code).

ApiCompat -> Comparing net7.0 reference assemblies against .NETStandard2.x and .NETCoreApp6.0...
C:\repos\runtime2\src\libraries\apicompat\ApiCompat.proj(82,5): error : Compat issues with assembly mscorlib:
C:\repos\runtime2\src\libraries\apicompat\ApiCompat.proj(82,5): error : CannotChangeAttribute : Attribute 'System.Runtime.Versioning.UnsupportedOSPlatformAttribute' on 'System.IO.FileStream.Lock(System.Int64, System.Int64)' changed from '[UnsupportedOSPlatformAttribute("ios")]' in the contract to '[UnsupportedOSPlatformAttribute("freebsd")]' in the implementation.
C:\repos\runtime2\src\libraries\apicompat\ApiCompat.proj(82,5): error : CannotChangeAttribute : Attribute 'System.Runtime.Versioning.UnsupportedOSPlatformAttribute' on 'System.IO.FileStream.Unlock(System.Int64, System.Int64)' changed from '[UnsupportedOSPlatformAttribute("ios")]' in the contract to '[UnsupportedOSPlatformAttribute("freebsd")]' in the implementation.
C:\repos\runtime2\src\libraries\apicompat\ApiCompat.proj(82,5): error : Compat issues with assembly netstandard:
C:\repos\runtime2\src\libraries\apicompat\ApiCompat.proj(82,5): error : CannotChangeAttribute : Attribute 'System.Runtime.Versioning.UnsupportedOSPlatformAttribute' on 'System.IO.FileStream.Lock(System.Int64, System.Int64)' changed from '[UnsupportedOSPlatformAttribute("ios")]' in the contract to '[UnsupportedOSPlatformAttribute("freebsd")]' in the implementation.
C:\repos\runtime2\src\libraries\apicompat\ApiCompat.proj(82,5): error : CannotChangeAttribute : Attribute 'System.Runtime.Versioning.UnsupportedOSPlatformAttribute' on 'System.IO.FileStream.Unlock(System.Int64, System.Int64)' changed from '[UnsupportedOSPlatformAttribute("ios")]' in the contract to '[UnsupportedOSPlatformAttribute("freebsd")]' in the implementation.
C:\repos\runtime2\src\libraries\apicompat\ApiCompat.proj(82,5): error : Compat issues with assembly System.IO.FileSystem:
C:\repos\runtime2\src\libraries\apicompat\ApiCompat.proj(82,5): error : CannotChangeAttribute : Attribute 'System.Runtime.Versioning.UnsupportedOSPlatformAttribute' on 'System.IO.FileStream.Lock(System.Int64, System.Int64)' changed from '[UnsupportedOSPlatformAttribute("ios")]' in the contract to '[UnsupportedOSPlatformAttribute("freebsd")]' in the implementation.
C:\repos\runtime2\src\libraries\apicompat\ApiCompat.proj(82,5): error : CannotChangeAttribute : Attribute 'System.Runtime.Versioning.UnsupportedOSPlatformAttribute' on 'System.IO.FileStream.Unlock(System.Int64, System.Int64)' changed from '[UnsupportedOSPlatformAttribute("ios")]' in the contract to '[UnsupportedOSPlatformAttribute("freebsd")]' in the implementation.
C:\repos\runtime2\src\libraries\apicompat\ApiCompat.proj(82,5): error : Compat issues with assembly System.Runtime:
C:\repos\runtime2\src\libraries\apicompat\ApiCompat.proj(82,5): error : CannotChangeAttribute : Attribute 'System.Runtime.Versioning.UnsupportedOSPlatformAttribute' on 'System.IO.FileStream.Lock(System.Int64, System.Int64)' changed from '[UnsupportedOSPlatformAttribute("ios")]' in the contract to '[UnsupportedOSPlatformAttribute("freebsd")]' in the implementation.
C:\repos\runtime2\src\libraries\apicompat\ApiCompat.proj(82,5): error : CannotChangeAttribute : Attribute 'System.Runtime.Versioning.UnsupportedOSPlatformAttribute' on 'System.IO.FileStream.Unlock(System.Int64, System.Int64)' changed from '[UnsupportedOSPlatformAttribute("ios")]' in the contract to '[UnsupportedOSPlatformAttribute("freebsd")]' in the implementation.
Author: Jozkee
Assignees: Jozkee
Labels:

area-System.IO
Milestone: 7.0.0

@jozkee jozkee added the blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' label May 5, 2022
@jozkee
Copy link
Member Author

jozkee commented May 5, 2022

cc @ericstj @joperezr @adamsitnik @dotnet/area-infrastructure-libraries

@jozkee jozkee mentioned this issue May 5, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label May 5, 2022
@runfoapp runfoapp bot mentioned this issue May 5, 2022
Closed
@net-helix net-helix bot removed this from the 7.0.0 milestone May 6, 2022
@ghost ghost added the untriaged New issue has not been triaged by the area owner label May 6, 2022
@ghost ghost removed untriaged New issue has not been triaged by the area owner in-pr There is an active PR which will close this issue when it is merged labels May 6, 2022
@GrabYourPitchforks GrabYourPitchforks mentioned this issue May 11, 2022
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Jun 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jozkee jozkee

Labels
area-System.IO blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms'
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update ApiCompat to exclude UnsupportedOSPlatform["freebsd"] on Lock/Unlock jozkee/runtime
2 participants
@davidwrighton @jozkee