Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tar API PR accidentally reverted another PR #70575

Closed
cremor opened this issue Jun 10, 2022 · 3 comments · Fixed by #70617
Closed

Tar API PR accidentally reverted another PR #70575

cremor opened this issue Jun 10, 2022 · 3 comments · Fixed by #70617
Assignees
Milestone

Comments

@cremor
Copy link

cremor commented Jun 10, 2022

PR #67883 by @carlossanlop created the method ArchivingUtils.AttemptSetLastWriteTime by moving its code out of the previously only call site. But it seems like something went wrong there, because the moved code wasn't exactly the same. The code in the new method AttemptSetLastWriteTime only catches UnauthorizedAccessException while the old code directly in ZipFileExtensions.ExtractToFile did catch all exceptions. So this reverted PR #63912 by @EatonZ.

Added code: https://github.com/dotnet/runtime/pull/67883/files#diff-23247c9ec493be8075d059e176db7ef75c268642f1efda7a01a438cc45513636
Removed code: https://github.com/dotnet/runtime/pull/67883/files#diff-9ee8cace4e5c7b1b15c3242da2bc0ed401bd870b9834263a1693ad914183b4b4 (load the diff for ZipFileExtensions.ZipArchiveEntry.Extract.cs)

I assume this was an accidental change, so this should be fixed so that all exceptions are cought again.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jun 10, 2022
@ghost
Copy link

ghost commented Jun 10, 2022

Tagging subscribers to this area: @dotnet/area-system-io-compression
See info in area-owners.md if you want to be subscribed.

Issue Details

PR #67883 by @carlossanlop created the method ArchivingUtils.AttemptSetLastWriteTime by moving its code out of the previously only call site. But it seems like something went wrong there, because the moved code wasn't exactly the same. The code in the new method AttemptSetLastWriteTime only catches UnauthorizedAccessException while the old code directly in ZipFileExtensions.ExtractToFile did catch all exceptions. So this reverted PR #63912 by @EatonZ.

Added code: https://github.com/dotnet/runtime/pull/67883/files#diff-23247c9ec493be8075d059e176db7ef75c268642f1efda7a01a438cc45513636
Removed code: https://github.com/dotnet/runtime/pull/67883/files#diff-9ee8cace4e5c7b1b15c3242da2bc0ed401bd870b9834263a1693ad914183b4b4 (load the diff for ZipFileExtensions.ZipArchiveEntry.Extract.cs)

I assume this was an accidental change, so this should be fixed so that all exceptions are cought again.

Author: cremor
Assignees: -
Labels:

area-System.IO.Compression, untriaged

Milestone: -

@ghost
Copy link

ghost commented Jun 11, 2022

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

PR #67883 by @carlossanlop created the method ArchivingUtils.AttemptSetLastWriteTime by moving its code out of the previously only call site. But it seems like something went wrong there, because the moved code wasn't exactly the same. The code in the new method AttemptSetLastWriteTime only catches UnauthorizedAccessException while the old code directly in ZipFileExtensions.ExtractToFile did catch all exceptions. So this reverted PR #63912 by @EatonZ.

Added code: https://github.com/dotnet/runtime/pull/67883/files#diff-23247c9ec493be8075d059e176db7ef75c268642f1efda7a01a438cc45513636
Removed code: https://github.com/dotnet/runtime/pull/67883/files#diff-9ee8cace4e5c7b1b15c3242da2bc0ed401bd870b9834263a1693ad914183b4b4 (load the diff for ZipFileExtensions.ZipArchiveEntry.Extract.cs)

I assume this was an accidental change, so this should be fixed so that all exceptions are cought again.

Author: cremor
Assignees: -
Labels:

area-System.IO, untriaged

Milestone: -

@carlossanlop carlossanlop self-assigned this Jun 11, 2022
@carlossanlop carlossanlop added this to the 7.0.0 milestone Jun 11, 2022
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Jun 11, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jul 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants