Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StreamContent.ReadOnlyStream fails Stream conformance tests #70725

Closed
MihaZupan opened this issue Jun 14, 2022 · 1 comment · Fixed by #70731
Closed

StreamContent.ReadOnlyStream fails Stream conformance tests #70725

MihaZupan opened this issue Jun 14, 2022 · 1 comment · Fixed by #70731
Assignees
@stephentoub
Labels
area-System.Net.Http bug
Milestone
7.0.0

Comments

@MihaZupan
Copy link
Member

StreamContent's stream implementation does not pass StreamConformanceTests.

Some issues:

  • WriteTimeout should throw an InvalidOperationException instead of NotSupportedException
  • Flush(Async) should no-op instead of throwing

We should fix the above two issues and consider writing a stream conformance test for this stream.
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jun 14, 2022
@ghost
Copy link

ghost commented Jun 14, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

StreamContent's stream implementation does not pass StreamConformanceTests.

Some issues:

  • WriteTimeout should throw an InvalidOperationException instead of NotSupportedException
  • Flush(Async) should no-op instead of throwing

We should fix the above two issues and consider writing a stream conformance test for this stream.

Author: MihaZupan
Assignees: -
Labels:

bug, area-System.Net.Http
Milestone: -

@stephentoub stephentoub self-assigned this Jun 14, 2022
@stephentoub stephentoub mentioned this issue Jun 14, 2022
Merged
@karelz karelz added this to the 7.0.0 milestone Jun 14, 2022
@karelz karelz removed the untriaged New issue has not been triaged by the area owner label Jun 14, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jul 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@stephentoub stephentoub

Labels
area-System.Net.Http bug
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Fix a few Stream-related issues in System.Net.Http stephentoub/runtime
3 participants
@stephentoub @karelz @MihaZupan