Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regressions in System.Text.Json.Serialization.Tests.ColdStartSerialization<SimpleStructWithProperties> #71645

Closed
performanceautofiler bot opened this issue Jun 28, 2022 · 6 comments
Labels

Comments

@performanceautofiler
Copy link

Run Information

Architecture x64
OS alpine 3.15
Baseline d3f7e0145437ca3afe7d8a0bab38cc95040cfc28
Compare d17741d0c44b13cb4df864e0184cf1e499edcd57
Diff Diff

Regressions in System.Text.Json.Serialization.Tests.ColdStartSerialization<SimpleStructWithProperties>

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
NewCustomConverter - Duration of single invocation 19.81 μs 25.58 μs 1.29 0.20 False

graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Text.Json.Serialization.Tests.ColdStartSerialization&lt;SimpleStructWithProperties&gt;*'

Payloads

Baseline
Compare

Histogram

System.Text.Json.Serialization.Tests.ColdStartSerialization<SimpleStructWithProperties>.NewCustomConverter


Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 25.582088141025643 > 20.891587583097515.
IsChangePoint: Marked as a change because one of 6/22/2022 6:53:40 PM, 6/28/2022 10:14:54 AM falls between 6/19/2022 8:44:36 PM and 6/28/2022 10:14:54 AM.
IsRegressionStdDev: Marked as regression because -29.89443457464828 (T) = (0 -25099.223019603156) / Math.Sqrt((394577.8292143935 / (38)) + (687117.9990430509 / (24))) is less than -2.0002978220134566 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (38) + (24) - 2, .025) and -0.30762440220043824 = (19194.520213424283 - 25099.223019603156) / 19194.520213424283 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@performanceautofiler performanceautofiler bot added alpine 3.12 untriaged New issue has not been triaged by the area owner labels Jun 28, 2022
@kunalspathak kunalspathak changed the title [Perf] Changes at 6/22/2022 10:05:16 PM Regressions in System.Text.Json.Serialization.Tests.ColdStartSerialization<SimpleStructWithProperties> Jul 5, 2022
@kunalspathak
Copy link
Member

Related to #70435

@kunalspathak kunalspathak transferred this issue from dotnet/perf-autofiling-issues Jul 5, 2022
@ghost
Copy link

ghost commented Jul 5, 2022

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Run Information

Architecture x64
OS alpine 3.15
Baseline d3f7e0145437ca3afe7d8a0bab38cc95040cfc28
Compare d17741d0c44b13cb4df864e0184cf1e499edcd57
Diff Diff

Regressions in System.Text.Json.Serialization.Tests.ColdStartSerialization<SimpleStructWithProperties>

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
NewCustomConverter - Duration of single invocation 19.81 μs 25.58 μs 1.29 0.20 False

graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Text.Json.Serialization.Tests.ColdStartSerialization&lt;SimpleStructWithProperties&gt;*'

Payloads

Baseline
Compare

Histogram

System.Text.Json.Serialization.Tests.ColdStartSerialization<SimpleStructWithProperties>.NewCustomConverter


Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 25.582088141025643 > 20.891587583097515.
IsChangePoint: Marked as a change because one of 6/22/2022 6:53:40 PM, 6/28/2022 10:14:54 AM falls between 6/19/2022 8:44:36 PM and 6/28/2022 10:14:54 AM.
IsRegressionStdDev: Marked as regression because -29.89443457464828 (T) = (0 -25099.223019603156) / Math.Sqrt((394577.8292143935 / (38)) + (687117.9990430509 / (24))) is less than -2.0002978220134566 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (38) + (24) - 2, .025) and -0.30762440220043824 = (19194.520213424283 - 25099.223019603156) / 19194.520213424283 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Author: performanceautofiler[bot]
Assignees: dakersnar
Labels:

area-System.Text.Json, untriaged, refs/heads/main, RunKind=micro, Regression, CoreClr, x64, alpine 3.12

Milestone: -

@kunalspathak
Copy link
Member

rwq

@kunalspathak
Copy link
Member

Ubuntu/x64 regression: dotnet/perf-autofiling-issues#6401

@krwq
Copy link
Member

krwq commented Jul 5, 2022

@kunalspathak I think this is a dup of #71392

@krwq
Copy link
Member

krwq commented Jul 7, 2022

Closing as dup, please re-open if you think this is different

@krwq krwq closed this as completed Jul 7, 2022
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Jul 7, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 6, 2022
@jeffhandley jeffhandley added runtime-coreclr specific to the CoreCLR runtime arch-x64 and removed CoreClr labels Dec 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants