-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
System.Text.Json.SourceGeneration.UnitTests.GeneratorTests failing with OutOfMemoryException on net7.0-windows-Release-x86-CoreCLR_checked-Windows.10.Amd64.Open #71962
Comments
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue Details
|
is this consistent repro? this looks more like something wrong with machine rather than JSON |
We saw the same failure in libraries-jitstress on two different machines: |
@jakobbotsch this seems like it happened in the same run 2min apart from each other ( I'd be interested in seeing if we have more instances of this before investigating. |
libraries-jitstress runs many scenarios (different environment variables) and triggers multiple helix job runs simultaneously, so it is not surprising that the timestamps are close to each other since indeed the pipeline run that triggered them is the same. |
we should either fix memory consumption or disable memory heavy test cases in 7.0 |
Since this concerns unit testing for the source generator, wonder whether this could be related #71653 |
Is it important to run the generator tests on a checked runtime? If not why not just disable them |
Note: It has been problem only in 3 builds in last 60 days (see top post). Removing the blocking-clean-ci label for now. |
Actually, Kusto shows more failures -- see updated top post. Adding the label back. |
Failed again in: runtime-coreclr libraries-jitstress 20220727.1 Failed test:
Error message:
|
We need to disable for chk CLR as suggested above |
We are still hitting this on jit pipelines that run libraries tests frequently. Note that I believe the x86 host is not large address aware, so the 1.8 GB memory usage in my screenshot above is quite close to the 2.1 GB limit on x86. |
@krwq what do you propose here? |
Removing 'blocking-clean-ci' - the tests were disabled on non-Release runs in PR #73181 |
Affects:
Official run failures are typically on net7.0-windows-Release-x86-CoreCLR_checked-Windows.10.Amd64.Open
Frequency 4/20-8/5 (incl. PRs from Kusto):
Query, Log
The text was updated successfully, but these errors were encountered: