Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test failure System.Net.Quic.Tests.MsQuicTests.SetListenerTimeoutWorksWithSmallTimeout #72238

Closed
VincentBu opened this issue Jul 15, 2022 · 4 comments · Fixed by #72599
Closed

Test failure System.Net.Quic.Tests.MsQuicTests.SetListenerTimeoutWorksWithSmallTimeout #72238

VincentBu opened this issue Jul 15, 2022 · 4 comments · Fixed by #72599
Assignees
@ManickaP
Labels
area-System.Net.Quic os-windows
Milestone
7.0.0

Comments

@VincentBu
Copy link
Contributor

Run: runtime-libraries-coreclr outerloop 20220714.2

Failed test:

net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open

- System.Net.Quic.Tests.MsQuicTests.SetListenerTimeoutWorksWithSmallTimeout

net7.0-windows-Release-x64-CoreCLR_release-Windows.10.Amd64.Server2022.ES.Open

- System.Net.Quic.Tests.MsQuicTests.SetListenerTimeoutWorksWithSmallTimeout

net7.0-windows-Release-x64-CoreCLR_release-Windows.11.Amd64.Client.Open

- System.Net.Quic.Tests.MsQuicTests.SetListenerTimeoutWorksWithSmallTimeout

net7.0-windows-Release-x86-CoreCLR_release-Windows.10.Amd64.Server2022.ES.Open

- System.Net.Quic.Tests.MsQuicTests.SetListenerTimeoutWorksWithSmallTimeout

Error message:

Assert.Equal() Failure
Expected: ConnectionAborted
Actual:   ConnectionIdle


Stack trace
   at System.Net.Quic.Tests.QuicTestBase.AssertThrowsQuicExceptionAsync(QuicError expectedError, Func`1 testCode) in /_/src/libraries/System.Net.Quic/tests/FunctionalTests/QuicTestBase.cs:line 53
   at System.Net.Quic.Tests.MsQuicTests.SetListenerTimeoutWorksWithSmallTimeout() in /_/src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicTests.cs:line 584
--- End of stack trace from previous location ---
@VincentBu VincentBu added arch-x86 os-windows arch-x64 blocking-outerloop Blocking the 'runtime-coreclr outerloop' and 'runtime-libraries-coreclr outerloop' runs area-System.Net.Quic labels Jul 15, 2022
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jul 15, 2022
@ghost
Copy link

ghost commented Jul 15, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Run: runtime-libraries-coreclr outerloop 20220714.2

Failed test:

net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open

- System.Net.Quic.Tests.MsQuicTests.SetListenerTimeoutWorksWithSmallTimeout

net7.0-windows-Release-x64-CoreCLR_release-Windows.10.Amd64.Server2022.ES.Open

- System.Net.Quic.Tests.MsQuicTests.SetListenerTimeoutWorksWithSmallTimeout

net7.0-windows-Release-x64-CoreCLR_release-Windows.11.Amd64.Client.Open

- System.Net.Quic.Tests.MsQuicTests.SetListenerTimeoutWorksWithSmallTimeout

net7.0-windows-Release-x86-CoreCLR_release-Windows.10.Amd64.Server2022.ES.Open

- System.Net.Quic.Tests.MsQuicTests.SetListenerTimeoutWorksWithSmallTimeout

Error message:

Assert.Equal() Failure
Expected: ConnectionAborted
Actual:   ConnectionIdle


Stack trace
   at System.Net.Quic.Tests.QuicTestBase.AssertThrowsQuicExceptionAsync(QuicError expectedError, Func`1 testCode) in /_/src/libraries/System.Net.Quic/tests/FunctionalTests/QuicTestBase.cs:line 53
   at System.Net.Quic.Tests.MsQuicTests.SetListenerTimeoutWorksWithSmallTimeout() in /_/src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicTests.cs:line 584
--- End of stack trace from previous location ---
Author: VincentBu
Assignees: -
Labels:

arch-x86, os-windows, arch-x64, blocking-outerloop, area-System.Net.Quic
Milestone: -

@ManickaP ManickaP self-assigned this Jul 15, 2022
@ManickaP ManickaP removed the untriaged New issue has not been triaged by the area owner label Jul 15, 2022
@ManickaP ManickaP added this to the 7.0.0 milestone Jul 15, 2022
@runfoapp runfoapp bot mentioned this issue Jul 15, 2022
Closed
@karelz karelz removed arch-x86 arch-x64 blocking-outerloop Blocking the 'runtime-coreclr outerloop' and 'runtime-libraries-coreclr outerloop' runs labels Jul 21, 2022
@karelz
Copy link
Member

karelz commented Jul 21, 2022 •
edited
Loading

Failures on both x86 and x64, Windows only

Failures only 7/14-7/18 (always in last retry, no PassedOnRerun). It seems to be gone (no failures 7/19-7/21) - removing 'blocking-outerloop'.
@ManickaP @CarnaViire @rzikm any idea what might have addressed it? Perhaps we should close it and wait for other occurrences?

let failedTests = (methodName : string, includePR : bool, messageSubstr: string, includePassedOnRerun : bool) {
cluster('engsrvprod.kusto.windows.net').database('engineeringdata').AzureDevOpsTests
    | where TestName startswith "System.Net" 
        and includePassedOnRerun or (Outcome == 'Failed')
    | extend startOfTestName = indexof_regex(TestName, @"[^.]+$")
    | extend Method = substring(TestName, startOfTestName)
    | extend Type = substring(TestName, 0, startOfTestName - 1)
    | project-away startOfTestName
    | where Method == methodName
    | where Message contains messageSubstr
    | distinct JobId, WorkItemId, Message, StackTrace, Method, Type, Arguments, Outcome
    | join kind=inner (cluster('engsrvprod.kusto.windows.net').database('engineeringdata').Jobs
        | where ((Branch == 'refs/heads/main') or (Branch == 'refs/heads/master') or (includePR and (Source startswith "pr/")))
        | where Type startswith "test/functional/cli/"
            and not(Properties contains "runtime-staging")
        | summarize arg_max(Finished, Properties, Type, Branch, Source, Started, QueueName) by JobId
        | project-rename JobType = Type) on JobId
    | extend PropertiesJson = parse_json(Properties)
    | extend OS = replace_regex(tostring(PropertiesJson.operatingSystem), @'\((.*)\).*|([^\(].*)', @'\1\2')
    | extend Runtime = iif(PropertiesJson.runtimeFlavor == "mono", "Mono", iif(PropertiesJson.DefinitionName contains "coreclr", "CoreCLR", ""))
    | extend TargetBranch = extractjson("$.['System.PullRequest.TargetBranch']", Properties)
    | extend Architecture = PropertiesJson.architecture
    | extend Scenario = iif(isempty(PropertiesJson.scenario), "--", PropertiesJson.scenario)
    //| extend DefinitionName = PropertiesJson.DefinitionName
    | project-away PropertiesJson
};
failedTests('SetListenerTimeoutWorksWithSmallTimeout', true, '', true);

@ManickaP
Copy link
Member

It's still happening on main, I have a fix ready, PR will be up today.

@ManickaP ManickaP self-assigned this Jul 21, 2022
@ManickaP ManickaP mentioned this issue Jul 21, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jul 21, 2022
@VincentBu
Copy link
Contributor Author

Failed again in : runtime-libraries-coreclr outerloop 20220724.3

Failed test:

net7.0-windows-Release-x64-CoreCLR_release-Windows.10.Amd64.Server2022.ES.Open

- System.Net.Quic.Tests.MsQuicTests.SetListenerTimeoutWorksWithSmallTimeout

net7.0-windows-Release-x64-CoreCLR_release-Windows.11.Amd64.Client.Open

- System.Net.Quic.Tests.MsQuicTests.SetListenerTimeoutWorksWithSmallTimeout

net7.0-windows-Release-x86-CoreCLR_release-Windows.11.Amd64.Client.Open

- System.Net.Quic.Tests.MsQuicTests.SetListenerTimeoutWorksWithSmallTimeout

net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open

- System.Net.Quic.Tests.MsQuicTests.SetListenerTimeoutWorksWithSmallTimeout

net7.0-windows-Release-x86-CoreCLR_release-Windows.10.Amd64.Server2022.ES.Open

- System.Net.Quic.Tests.MsQuicTests.SetListenerTimeoutWorksWithSmallTimeout

Error message:

Assert.Equal() Failure
Expected: ConnectionAborted
Actual:   ConnectionIdle


Stack trace
   at System.Net.Quic.Tests.QuicTestBase.AssertThrowsQuicExceptionAsync(QuicError expectedError, Func`1 testCode) in /_/src/libraries/System.Net.Quic/tests/FunctionalTests/QuicTestBase.cs:line 60
   at System.Net.Quic.Tests.MsQuicTests.SetListenerTimeoutWorksWithSmallTimeout() in /_/src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicTests.cs:line 628
--- End of stack trace from previous location ---

@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jul 26, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ManickaP ManickaP

Labels
area-System.Net.Quic os-windows
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

[QUIC] Remove connection state from QuicStream ManickaP/runtime
3 participants
@karelz @ManickaP @VincentBu