-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] Ensure subtleCrypto is usable from Blazor app #72810
Comments
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsThere are potentially several things blocking it from working
|
also related to #69741 |
After this arrives to Blazor via SDK, we will attempt to load the We need to add |
The current runtime code is using |
Also, the file as is doesn't have any hash or cache policy. |
@pavelsavara @radical and I talked about this. It would be ideal if the runtime does not hardcode any path and receives this data as part of the initialization process. We likely want to add a version hash to the file in the same way we do for dotnet.js, and in general, we want control over anything that loads over a fetch request. (In other words, the runtime should not hardcode the logic related to how things work, as we might want to change it in the future or needs to be tweaked depending on the scenario. |
Yes, but your custom startup sequence is already nightmare for us. So it would be better if we don't make it worse by handling modules of the runtime in separate way as well. My draft dotnet/aspnetcore#42770 doesn't deal with JS assets, but passing us the list of assets with hashes is the right way how to do it. |
@pavelsavara cool, that's very much inline with what @radical and myself discussed. We mostly care about what @SteveSandersonMS commented on the relevant issue. As long as we maintain the current functionality, we should be good, for example, we wouldn't want to start imposing a concrete file layout on the deployed apps. |
JFYI, this will need a test in runtime/src/tests/BuildWasmApps/Wasm.Build.Tests/WasmTemplateTests.cs Lines 268 to 277 in bf56a7c
|
cc @jeffhandley - FYI |
Closing in favor of #73858 . Please re-open if needed for some reason. |
There are potentially several things blocking it from working
The text was updated successfully, but these errors were encountered: